Skip to content

Random improvements #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Random improvements #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"runtimeExecutable": "yarn",
"runtimeArgs": ["test:standalone"],
"runtimeArgs": ["test:theia"],
"presentation": {
"group": "GLSP-Playwright launch configurations",
"order": 1
Expand Down
4 changes: 2 additions & 2 deletions examples/workflow-test/src/graph/elements/label-heading.po.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/
import { Mix, Renameable, useClickableFlow } from '@eclipse-glsp/glsp-playwright/extension';
import { Mix, useClickableFlow, useRenameableFlow } from '@eclipse-glsp/glsp-playwright/extension';
import { ModelElementMetadata, PLabel } from '@eclipse-glsp/glsp-playwright/glsp';

export const LabelHeadingMixin = Mix(PLabel).flow(useClickableFlow).flow(Renameable).build();
export const LabelHeadingMixin = Mix(PLabel).flow(useClickableFlow).flow(useRenameableFlow).build();

@ModelElementMetadata({
type: 'label:heading'
Expand Down
2 changes: 2 additions & 0 deletions examples/workflow-test/src/graph/elements/task-automated.po.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
Mix,
useClickableFlow,
useCommandPaletteCapability,
useDraggableFlow,
useHoverableFlow,
useMarkerCapability,
usePopupCapability,
Expand All @@ -28,6 +29,7 @@ import { LabelHeading } from './label-heading.po';
export const TaskAutomatedMixin = Mix(PNode)
.flow(useClickableFlow)
.flow(useHoverableFlow)
.flow(useDraggableFlow)
.capability(useResizeHandleCapability)
.capability(usePopupCapability)
.capability(useCommandPaletteCapability)
Expand Down
4 changes: 4 additions & 0 deletions examples/workflow-test/src/graph/elements/task-manual.po.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ import {
useClickableFlow,
useCommandPaletteCapability,
useDeletableFlow,
useDraggableFlow,
useHoverableFlow,
usePopupCapability,
useRenameableFlow,
useResizeHandleCapability
} from '@eclipse-glsp/glsp-playwright/extension';
import { ChildrenAccessor, NodeMetadata, PNode, SVGMetadataUtils } from '@eclipse-glsp/glsp-playwright/glsp';
Expand All @@ -30,6 +32,8 @@ export const TaskManualMixin = Mix(PNode)
.flow(useClickableFlow)
.flow(useHoverableFlow)
.flow(useDeletableFlow)
.flow(useDraggableFlow)
.flow(useRenameableFlow)
.capability(useResizeHandleCapability)
.capability(usePopupCapability)
.capability(useCommandPaletteCapability)
Expand Down
4 changes: 2 additions & 2 deletions packages/glsp-playwright/src/extension/flows/rename.flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ export interface Renameable {
* The renaming is done by utilizing the edit label functionality.
*
* @param Base Base class that should be extended
* @returns Extended base class with the {@link Renameable} flow
* @returns Extended base class with the {@link useRenameableFlow} flow
*/
export function Renameable<TBase extends ConstructorA<Locateable & Clickable>>(Base: TBase): Flow<TBase, Renameable> {
export function useRenameableFlow<TBase extends ConstructorA<Locateable & Clickable>>(Base: TBase): Flow<TBase, Renameable> {
abstract class Mixin extends Base implements Renameable {
/**
* Rename the element.
Expand Down