Conversation
martin-fleck-at
left a comment
There was a problem hiding this comment.
Hi @Sakrafux! Thank you for the great overall work! I do have some comments and questions regarding parts of the code but I am a big fan of the overall ideas and configurability. Since we are not merging into main (yet), this definitely does not need to be perfect but I would love to get your thoughts and feedback on some of the comments.
examples/workflow-server/src/common/handler/create-decision-node-handler.ts
Show resolved
Hide resolved
packages/server/src/common/gmodel/gmodel-create-node-operation-handler.ts
Outdated
Show resolved
Hide resolved
| ); | ||
| // A connection may be unceremoniously be closed (e.g., closing/reloading the browser) in which | ||
| // case the server must still be disposed | ||
| serverInstance.clientConnection.onClose(() => this.disposeServerInstance(serverInstance)); |
There was a problem hiding this comment.
Have you checked whether this accounts for the reconnect behavior? But overall this looks good.
There was a problem hiding this comment.
No, I haven't checked and now that you mention it, this would likely cause issues on reconnect.
Maybe it would be better to set-off a beacon from the client with JsonrpcGLSPClient.ShutdownNotification, because the main issue is closing/reloading the browser and the current version treats every closed connection (which includes reconnect) the same. However, as this concerns the greater server life cycle, I would hand this over to you.
Extends the GLSP MCP Server started in PR-120 according to our meetings @martin-fleck-at.