-
Notifications
You must be signed in to change notification settings - Fork 209
Specification and BaseRepositotyProvider improvements #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bogdan-bondar
merged 7 commits into
eclipse-hawkbit:master
from
bosch-io:feature_scoped_repo_read
Oct 21, 2021
Merged
Specification and BaseRepositotyProvider improvements #1182
bogdan-bondar
merged 7 commits into
eclipse-hawkbit:master
from
bosch-io:feature_scoped_repo_read
Oct 21, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
|
Can one of the admins verify this patch? |
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
bogdan-bondar
approved these changes
Oct 21, 2021
Contributor
bogdan-bondar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
krishna-devolo
added a commit
to devolo/hawkbit
that referenced
this pull request
Sep 28, 2023
* Bump docker setup to 0.3.0M7
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Proxy support for sandbox fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* upgraded Vaadin to 8.12.3
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* How to report vulnerability
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Security chapter added and minor formatting issues fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* adapted DEPENDENCIES list, changed vaadin themes CQ to 8.12.3
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Migration to JUnit5 as default test runtime (#1082)
* Migrate tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* REST docs tests migrated to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Migrated security and UI tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Migrated management tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Reflecting changes from JUnit5 migration
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Fix RabbitMQ test detection
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Drop support for JUnit4
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Fix the creation of the Usage Report (#1101)
* Use the forEachTenant method to generate the report for each tenant.
* add a test to verify the functionality of getSystemUsageStatisticsWithTenants
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Introduce new tenant configuration events (#1059)
* Introduce new events that are triggered when changes are made to the tenant configuration.
* Add new events to EventTypes
* Fix DeploymentManagement tests.
* Fix AmqpMessageDispatcherServiceIntegration tests.
* Fix DdiRootControlle test.
* Remove unused imports.
* TenantConfigUpdatedEvent should implement EntityUpdatedEvent
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Feature/remove junit5 leftovers (#1097)
* Migrate JUnit4 leftovers to JUnit5
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix method name typos
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Avoid unnecessary Mockito stubbings
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Replace assertThrows by assertThatExceptionOfType, fix test TODO
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix error for downloading soft deleted artifact binary (#1102)
* download soft deleted artifact throws binary gone exception
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add test and update documentation
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix javadoc
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* test soft deleted artifact has no download link
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Use TargetManagement for the quota related count operation when activating auto assignment instead of performing this operation directly on the repository. (#1108)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix output folder for REST docu tests (#1109)
* Fix output folder for REST docu tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add description to abstract method
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Execute rollouts and auto assignments in the correct user context (#1100)
* Execute rollouts and auto assignments in correct user context
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix PR review findings
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Cleanup usage of lenient
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* UI error handling refactoring (#1106)
* refactored HawkbitUIErrorHandler to delegate error details extraction to external extractor beans
* refactored ui error handling, allowed ui error details extractors to return a list of error details
* added license headers, restructured package structure
* adapted javadocs
* fixed sonar findings
* fixed license header
* added tests for HawkbitUIErrorHandler
* refactored ConstraintViolationErrorExtractor, added test for extractors
* changed UI tests feature to Management UI
* fixed the parent/child error type resolution by ui error details extractor, added test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Refactor AutoAssignExecutor to improve the extensibility (#1110)
* Refactor AutoAssignExecutor to improve the extensibility.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* introduce protected getters
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor auto assign executor. Create deployment requests based on list of controllerIds.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix review findings
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Surround consumer with a try catch block to continue assignment process for other filter. Execute assignment in user context.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix the action status icon "CANCEL_REJECTED" because it was displayed as unknown (#1115)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* ManagementApi: Action does not have property containing rollout name (#1116)
* Mgmt Rest API: Enhance Action payload with rollout properties
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Enhance Mgmt REST API docs
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Minor changes
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Simplified JpaRolloutManagement, moved rollout handling logic to JpaRolloutHandler (#1094)
* introduce RolloutExecutor
* removed unused method
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* Fix test name in order to get executed by surefire (#1117)
* Fix test name in order to get executed by surefire
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix expected group amount for outer query
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Removed flyway downgrade so that spring default is pickedup (#1114)
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Injectable UI target data suppliers (#1123)
* initial proposal for injectible target data provider
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* improved selection of first entity in grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced constructor to explicitely set DataCommunicator for a Grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* made data communicator for target grid injectable
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted size page request to load only one entity for getting total elements, fixed grid duplicates in case lastModified property is the same for targets and rollouts
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* DeleteSupport rethrows the exception to be intercepted by error handlers
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* minor grid refactoring
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted docu for base data providers
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added custom filter data provider, made filter effectively immutable by cloning before data refresh
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* grid returns size directly from data provider instead of data communicator
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* restructured data provider/communicator dependency injection, added injectable data supplier for target filter view grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* do not remove confirmation dialog window from UI explicitely
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed sonar, added docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added remote entity events dispatch topic to be fired on deffered events dispatch (#1129)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Remove wrong license header (#1127)
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Set DdiActionFeedback ID deprecated (#1091)
* Deprecate DdiActionFeedback ID
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Add deprecation to FEEDBACK_ACTION_ID in docu
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* PopUp dialog for canceling queued uploads (#1112)
* added cancel dialog for queued uploads
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix PR review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix sonar finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed DashboardMenu navigation
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Consider Target Fields when validating RSQL filters (#1121)
* Removed unnecessary DB queries when editing/validating RSQL query in Target Filter Management (#1023)
Added valid TargetFields to RSQL validation when editing Target Filter.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Corrected visit OrNode implementation.
Changed isValid to receive FieldNameProvider as parameter
Reduced code duplication by moving commonly used utility methods to AbstractFieldNameRSQLVisitor from ValidationRSQLVisitor abd JpqQueryRSQLVisitor
Refactored and extended Unit Tests.
Minor corrections and typos.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Added Maven entry for devolo 2020 copyright header.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Fix failing unit tests
* # WARNING: head commit changed in the meantime
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix Sonar findings.
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Cleanup
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix PR review findings
* Fix invalid queries in unit tests
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Added test case to create filter with invalid query via Mgmt REST API
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
Co-authored-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Added userinfo endpoint to validate basic auth (#1131)
* Added userinfo endpoint to validate basic auth
* Fixed the bean exception for failing tests
* Added tests for userinfo endpoint with basic auth
* Added the missing license header
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Publish target assign event (#1136)
* Throw the TargetAssignDistributionSetEvent even if there are actions in CANCELING state present. Filter the actions on the receiver side. In this case at the DMF.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix deploymentManagementTest
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Add debug logs and fix tests to verify correct DMF message behaviour
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Extend test case for the DMF in case the cancel is confirmed by the device
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Remove unsued import
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix review findings by filtering the list of targets first before querying the database for distribution set and software module.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* flip list verification logic
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor amqp tests
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* suppressed functional interface sonar issue for MgmtBasicAuthRestApi
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Support case-insensitive RSQL expressions /target filters (#1137)
* Interpret /parse RSQL expressions case insensitive
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Add unit test verifying that RSQL expressions are case insensitive
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Feature/handle amqp fatal errors (#1111)
* Adding support to handle lengthy error msgs more precisely
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Added check at conditionalHandler level and changes assertions in test class
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixed sonar lint issues
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Reverted the change on making class final
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* To trigger the circle-ci build and check
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Addressed last set of PR comments
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixe sonar issue for nullpointer dereference
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Handling null case explicitly
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Make RSQL visitor pluggable via a managed bean (#1145)
* Add a managed bean for a RsqlVisitorFactory
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix failing unit tests
* Fix Sonar findings
* Fix PR review findings
* View-scoped event listeners (#1134)
* added UI EntityNotFound error details extractor
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed Target count label to not rely on grid data change events but rather on EntityModified UI events to decide how to react dependand on the event type
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added current view check on entity modified events
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* unsubscribe/resubscribe event listeners on view leave/enter, reselect grid entities on view enter
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed target grid count reset on initial load and after view change
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* re-evaluate filters on Deployment View enter
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added on view enter logic for rest of the views
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced event listener aware layout and view, adapted code accordingly
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed bulk upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added missing docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted software module deselection upon master entity change
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed npe in case master support is not present (Artifact View)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* restructured amqp assignDistributionSetMultipleTimes test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added waiting for the messages to be dispached by test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Optional controller attributes for THING_CREATED (#1154)
* added optional attributes payload to THING_CREATED DMF message
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added optional attributes unit test for THING_CREATED message handler
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* extended Target interface with getControllerAttributes method, extended DMF message handler integration tests
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* updated hawkbit docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed review findings
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Set key of DistributionSetType and SoftwareModuleType required (#1140)
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Replace NoCountPagingRepository by interface with dedicated findAllWithoutCount (#1146)
* Replace NoCountPagingRepository by enhanced BaseRepository
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add missed withoutcount call in distributionsettype find all
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add missing overrides to NoCountRepository implementation
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Remove need of repository by referencing base class directly in configuration
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Align target queries to only use specifications (#1148)
* Add additional specifications to cover use cases of queries
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Replace reading target queries by spec, use empty spec in default repo calls
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Use correct NonNull annotation
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Added default exists based on spec count to TargetRepository
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Feature/enforce hash validation for uploads (#1158)
* moved artifact duplication check after hash check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added unit tests
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed copyright header
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Feature target type entity (#1162)
* Added Target Type model
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type JPA model
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type repository model classes
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the name entity from Target Type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Refactored the Target Type models
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added the DB migration script and updated the Target Type models
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type in target Mapper
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Changed the target type ID to Long
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added MYSQL DB migration script and removed the deleted column for target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Updated the DB migration script for target table
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added manyToMany reltation between target type and Ds type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added POSTGRESQL DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added MSSQL SERVER DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added DB2 DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing license header and java docs
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added on delete cascade in DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type specification
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the delete cascade and Added type API
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* fixed API doc build
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type management test
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type events test
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type update and unassign to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added API tests for assigning target type to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing license header
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing docs
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed sonar issues
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed license header build issue
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Updated the attribute name to target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed unused error status variable
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target API to assign target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added the tests for assigning target type to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the review comments for null check
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fix sonar/repository for target type (#1169)
* fix sonar/repository for target type changes
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* review finding
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Dependency upgrades (#1170)
* Increase jsoup version
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* bumped vaadin/guava/common-io to newest versions
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* substituted deprecated guava create temp dir method
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fix null pointer exception in rsql target field validation test (#1172)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Colour property in Mgmt API response for DS/SM type (#1174)
* Update name SP to hawkbit in api guide adocs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix javadoc class descriptions of existing resource/api classes
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add color property to api response of ds/sw type
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add color property to sw type test data & adapt rest docu
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add missing property description for "colour" and "deleted"
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Test: max DS Types per TargetType (#1175)
* add dsTypes in targetType quota test
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* README: add mention to Hara and hara-ddiclient (#1173)
Add a mention to the Eclipse Hara project and the hara-ddiclient library
that has been pushed recently to the Eclipse Foundation repositories.
Rework a bit the text to reflect this change.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* Introduce basic functionality for invalidation of distributionsets (#1179)
* Basic DS invalidation functionality
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add checks for valid/complete DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Stop rollouts + auto assignments when invalidating a DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add methods to count AAs + rollouts for invalidation
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Small refactoring for DS management
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add invalidation functionality to REST API
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix update stopped rollouts status
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add various tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Introduce countActionsForInvalidation
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix event tests with incomplete DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add H2 migration script
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix action count method
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix REST documentation tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Change flyway version number
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add lock for DS invalidation + adapt tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move concurrency test to own class
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Handle possible InterruptedException
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix concurrency test
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Use one transaction for all invalidations
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add invalidate endpoint to REST docu
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Execute invalidation in transaction when actions are cancelled
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Check that distribution set is valid when editing/creating metadata
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Remove all changes in UI
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add DB migration files for all databases
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Implement review findings
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move DS invalidation to own class to check permissions for single steps
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move invalidation count methods to management classes
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix failing tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Feature invalidation of distribution sets [UI part] (#1176)
* Visualization of action/button invalidate DistributionSet
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* introduced two dialogs to confirm ds invalidation
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed dialog titles appear centered and added manamgement classes
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* retrieving affected entities from repository
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* considered multiselection for invalidating dist sets
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* adapt style and tooltip of invalid distributions in grid
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* showing errors for actions not allowed for invalidate DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* enhanced error message with dist name and version
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added ids to the labels to be used in tests
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added support for overwriting entity specific edit behaviour
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed incorrect label for cancelled action due to invalidation of ds in
a rollout
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed error notification to not show "please try again" for an invalid
DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed Sonar findings
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* remove DS of a copied Rollout in case the DS is invalidated
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* changed icon of RolloutActionStatus in case of stopped Rollout because
of invalidation of DS and DS wasn't yet assigned to target. This is to
distinguish from the case of not assigned DS because of duplicate DS
assignemnt
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Prevent editing Metadata of invalid DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* show DS as invalidated in Rollout view
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* incorporated code review remarks
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* invalidated DS should be removed from the list of DS to be invalidated
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed missing code due to merge
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed compile error due to rebase
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* README.md: Add rauc-hawkbit-updater to the list of clients supporting hawkBit (#1181)
Also add the word 'demo' to the python variant to give a hint to not use
this for real-world applications.
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
* Feature mass cancel running actions on ds invalidation (#1177)
* Extend DS invalidation dialog to include mass-cancellation of actions
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
add component id for cancelation type radio buttons
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add infos about ds invalidation to UI documentation;
update UI images; add screenshot about ds invalidation
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add link property to invalidation docu
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Put invalidation counts into one object
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add hint to invalidation dialog, that invalidation is unrepeatable
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* disable invalidate button if insufficient permission
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix auto assignment error with insufficient permission
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* implement permissions check for invalidation dialog
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add update_target permission to api doc description
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Feature target with target type in UI (#1178)
* Added the target type combo box to add or update Target in UI
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed NPE for empty target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type option to target bulk upload
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target type filter
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Named entity mapper for target type UI
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed sonar issues for serialization
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Bulk upload target type combo box
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Feature - TargetType compatibility check (#1180)
* added targettype compatibility check in deployment
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added targettype compatibility for autssignment
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added / fixed tests for auto assignment compatibility check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* adapted rollout creation to use JPA specifications for compatibility checks
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix unit tests and javadoc
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix copyright header
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* replaced validated-DS management calls
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* improved compatibility check in DeploymentManagementTest
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Vaadin security upgrade to 8.14.1 (#1188)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Docu for target type endpoints in Target API (#1185)
* add assign/unassign type endpoints to target api docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix target type creation for api rest docs test
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments: rename tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* adapt test to avoid failing when translated
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix api doc tests in regard to type compatibility (#1191)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Ensure a '.' character is allowed to be used in target filter query for metadata key and attribute name (#1186)
* Adapted code to allow '.' inside of metadata key and attribute names
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added handling of corner cases
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Adapted metadata and attribute tests to check that dot is allowed
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed documentation
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Allow usage of dot in key names for every map attribute, e.g. also for
metadata in distribution set
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* adapted test key to ensure a dot can be used
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Support keywords in queries (#1193)
* support targettype as keyword in target-queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* support valid as keyword in distributionset-queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* remove targettype.id from filter queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* remove targettype.description from filter queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Implement target type CRUD UI operations (#1184)
* implement target type CRUD UI operations
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix licenses
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* code clean up
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* code clean up
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* refactor proxy target type
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* refactor proxy target type
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* update class description
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix showing assigned ds types
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* remove unused import
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* Specification and BaseRepositotyProvider improvements (#1182)
* Introduce custom base repository factory bean
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Simplify ordered DS service call by using specs
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Annotate getBaseRepoType interface as FunctionalInterface
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Use CustomBaseRepositoryFactory instead of static BaseClass
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Fix license headers
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add ordered specification back
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* added Insufficient Permissions UI error extractor (#1196)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Adapt UI for target type compatibility check (#1189)
* Added compatibility calls needed for UI
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Adapted UI for target type compatibility checks
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* improved exception handling for incompatibility check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added & fixed unit tests
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed merged conflicts
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed target type incompatibly specification
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* changed UI behaviour to close assignment popup in case of IncompatibleTargetTypeException
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added unit test to validate incompatibly specification fix
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix potential null pointer
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Fixed rolloutcopy by adding dsTypeId to ProxyDistributionSetInfo
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* suppressed warning
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Feature target type filter (#1197)
* Added Target type filter with drag and drop support
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the unused enums and target type filter button class
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Resolved merge conflicts
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed java doc issue with the method link in the comment
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the IN query overflow for target Type assignment
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Remove mysql_user and update documentation (#1139)
* Remove mysql_user and update documentation
* MG, udpate based on maintainers feedback
* Remove extra comments for password, already in doc
* fixed compatibility check bug (#1198)
* fixed compatibility check bug & improved testing
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* reduced amount of targets in test
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* mention target type in docu (#1199)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Use an empty AMQP Message body instead of a null value (#1200)
* Artifact Encryption plug point (#1202)
* added ArtifactEncryption interface, injected it into SM creation UI module, added encryption metadata key generation upon SM creation, used encryptor during file upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* add default artifact encryption implementation based on gcm aes algorithm
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed ArtifactEncryptor interface to manage encryption secrets by itself
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* cleaned up stale code, fixed sonar
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed software module encryption within transaction
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added artifact encryption secrets store
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* extended ArtifactEncryption interface to allow decryption, secrets store provides removeSecret, added missing javadocs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* intriduced DbArtifact interface, use EncryptionAwareDbArtifact for artifact decryption during download
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced ArtifactEncryptionService to minimize duplications and unneccessary dependency injections
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* declared ArtifactEncryptionService as a bean
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added persistant encryption flag to software module
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* further adptations for encryption flag persistence
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added ArtifactEncryptionException, fixed encryption check in UI
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added encryption error handling
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added encrypted flag to DDI/DMF, adapted exception handling
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted rest docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Add test to verify artifact encryption is not given by default
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Add isEncrypted() to toString() of JpaSoftwareModule, fix typos
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix sql migration scripts
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Calculate encrypted artifact size by subtract encryption size overhead
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* publish upload failed without waiting for interuption during UI file upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* upgraded cron utils to 9.1.6
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Co-authored-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* added same origin x-frame-options header security config (#1207)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Make entity object of event optional (#1209)
* explicitly return an optional entity by an event
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix assertions in tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix distribution set tag api doc (#1219)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add license header for Bosch.IO 2022 (#1221)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* DDI API: /controller/v1/{controllerid}/installedBase/{actionId} (#1220)
* installedBase DDI: initial impl + rest docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* refactor installedBase implementation
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* ddi installed base tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* restructure root controller rest docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix some java docs and formatting
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* don't add action history message when calling /installedBase
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix test after removing action history message
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* set the JpaControllerManagement constructor public (#1227)
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Updated migration guide to include deprecated property (#1225)
* updated m7 migration to include spring boot deprecated property
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed hawkbit sandbox link
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Feature/fix sonar warnings (#1226)
* Fixed sonar warnings
- "Cognitive Complexity"
- "Do not use replaceAll when not using a regex"
- java:S5869 - Character classes in regular expressions should not contain the same character twice
- Improved bad name
- Typos
- reduced code duplications
- Replaced hand-made wait-utility with Awaitility
- Log messages
- Duplicate code
- Typos
- Removed Thread.sleep, instead relaxed check condition
- Removed use of deprecated API
- Removed use of deprecated API
- Added supress-warnings as I do not see a better way to write the tests
- Removed Thread.sleep / redundant functionality to Awaitility
- Fixed other warnings (use isZero, isEmpty, hasToString)
- Removed/Reduced duplicate code
- Added generics
- Fixed asserts
- removed: field.setAccessible(true) actually should not be needed for public static fields!
- Too long constructor passes arguments in wrong order - how surprisingly...
- Clean-up use of varargs arguments
- Fixed regex
- Fixed typos and other minor stuff
- Making public constructors protected in abstract classes
- Swapped expected and asserted argument
- volatile not enough for syncing threads
- volatile not enough for syncing threads
- out-commented code
- Made regex not-greedy, added tests for verification
- Avoid exposure of thread-local member var
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixed Sonar warnings
* License header fix
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* License header fix #2
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing review findings
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing tests
- Fixed '&' usage in javadoc and typos
- Fixing some warnings
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Feature/speedup quota tests (#1125)
* reduce the number of created entities in tests
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed tests
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed review findings
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* merged master
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* adapted target count
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed review findings
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed RolloutManagementTest
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed flaky test ConcurrentDistributionSetInvalidationTest
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* UI deep-linking for targets (#1230)
* added target deeplinking through url param
* populate search irregardless of target existence
* adapted view state paramater evaluation flow
* fixed review comments
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Fix installedBase link in DDI base resource (#1232)
* add test for installedBase bug
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix for test scenario I
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add another test scenario for installedbase bug
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add fix for scenario 2a+b
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Optimize UI queries (#1234)
* first iteration of query optimization for target and distribution set
* fixed type distribution set filter
* adapted all ui dataproviders to use repository count
* adapted test to not check target attributes within search query
* unified search behaviuor for ds and sm
* removed unneccessary count queries for some mgmt calls
* removed unneccessary type id proprty from ProxyDistributionSetInfo to minimize lazy fetches
* refactored mgmt classes
* removed duplication of name version filter
* fixed copy rollout compatibility check
* cleaned-up management left overs
* added index to rollouts table on tenant/status queries
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Fix overdue timestamp calculation permission (#1235)
* fixed overdue timestamp calculation permission error
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed method visibility
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* upgrade spring framework to 5.2.20 (#1243)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Extend event for entity events (#1250)
* Extend event information by it's first interface class and improve constructing the event by providing the directly only.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Check if entity interface is assignable from TenantAwareBaseEntity.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* improved debug logs for autoassignment (#1253)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Avoid using RegexRequestMatcher due to [CVE-2022-22978] (#1258)
* Use ant instead of regex matcher.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* fix ant matcher
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Do some cleanup and revert unnecessary changes.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Improve target management (#1260)
* Fix join type for targets with their assignedDs
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Override saveAll method and make use of it in the JpaTargetManagement
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Use unmodifiable list and flip transactional logic
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Initialize new list instead of an unmodifiable list.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix testdata factory
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Calculate target count asynchronously (#1263)
* first prototype
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* moved asynchrinous count caclucation to abstract footer support
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added asynchronous count details calculation
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed typo
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Provide API for auto assignment check for specific device (#1262)
* Extend the auto assign executor to execute a auto assignment check for a specific device.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* add tests and handle exceptions
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add unit test
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add Copyright header
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix Copyright header
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add authorization
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix exception handling and authorization
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* renaming
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Rename auto assignment functions
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Stefan Klotz <stefan.klotz@bosch.io>
* Make custom target filter table expandable (#1267)
* initial draft to maximize custom target filer table for better UX in case of long keys/names
* Set correct maximize icon identifier and fix problem with wrong db table structure.
* Remove unnecessary local variable.
* Fix db migration scripts
* Fix losing the target tag table when mac and minimizing target table.
* fixed minor styling, removed duplication
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* add SystemSecurityContext (#1269)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* changed cors configuration bean definition to be reusable under different routes (#1272)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Dmf batch support changes. (#1273)
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Update hawkbit-dmf/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/integration/AmqpMessageDispatcherServiceIntegrationTest.java
Co-authored-by: Bondar Bogdan <36962546+bogdan-bondar@users.noreply.github.com>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement code review comments.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Co-authored-by: Bondar Bogdan <36962546+bogdan-bondar@users.noreply.github.com>
* Update jsoup (#1276)
* upgraded jsoup to 1.15.3
* removed deprecated safe html annotation
* added own valid string jsoup validator, disabled hibernate parallel method declaration constraint
* adapted valid string validator
* static method
* return invalid value in case of processing exception
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Feature/java11 build (#1280)
* hawkBit on Java 11
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Preparing java 11 build
- Update eclipse-link maven plugin dependencies
- Fixing warnings, adopt to java-11 style
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Preparing java 11 build
- Fixing warnings, adapt to java-11 style
- Added since to deprecated
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing sonar warnings
- removed deprecated API
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing sonar warnings & failing test
- Added suppressWarning
- added WithSpringAuthorityRule to clean-up listener
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Compile warnings
- Test if final causes issues in tests
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Removed deprecated code
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Reverted changes
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Removed final as this causes invalid reflective access exceptions
- The eclipselink generated classes seem to modify the field directly
- update plugin version
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Upgrade eclipselink from 2.7.9 to 2.7.10
* Remove @deprecated endpoints from MgmtTargetTagResource
* Remove dependencies already defined in eclipselink-maven-plugin
* Try eclipselink 2.7.11-RC1
* Set project encoding to UTF-8
* Upgrade surefire and failsafe plugins to 3.0.0-M7
* Try fixed string instead of a random generated one
* Replace JsonBuilder by Jackson ObjectMapper usage
* Use JsonBuilder again
* Use APPLICATION_JSON_UTF8 instead of APPLICATION_JSON
* Try to replace com.vaadin.external.google:android-json by org.json:json
* Add debugging outputs
* Improve debugging outputs
* Improve debugging outputs
* Use Jackson instead of JsonBuilder
* Use Jackson instead of JsonBuilder 2nd part
* Use Spring json dependency
* Use eclipselink 2.7.11
* Fix RootControllerDocumentationTest
* Improve helper methods of AbstractDDiApiIntegrationTest
* Upgrade SpringBoot and SpringCloud versions
* Improve deprecation notice for 0.3.0M8
* Fix BaseAmqpServiceTest
* Fix SpecificationsBuilderTest
* Removed deprecated code
* Define maven-enforcer-plugin version
* Remove com.google.code.findbugs.jsr305
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Update circleci image to openjdk:openjdk:11.0.13-jdk-buster
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Fix javadoc generation and license check
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Fix review findings
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
Co-authored-by: Dominic Schabel <dominic.schabel@bosch.io>
Co-authored-by: Peter Vigier <Peter.Vigier@bosch.io>
Co-authored-by: Markus Block <markus.block@bosch-si.com>
* Introduce action status scoped custom code (#1277)
* Allow providing a custom code with an action status feedback to give more fine grained device specific details.
* Add ddi rest docs for new optional status code value.
* Provide new code value via mgmt api. Fix review findings.
* Fix failing tests
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Stefan Behl <stefan.behl@bosch.io>
* Adapt cancel flow (#1274)
* Adapt assignment events to communicate mass cancel operations within one event.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix edge cases identified by test failures. Adapt tests and reduce amount of published cancel events.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix license header
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor visibility of methods in assignment strategy classes. Avoid having empty action status messages.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix api docs
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Remove unused (public) methods from JsonBuilder (#1281)
* Provide target quicklinks from Target Filters and Rollout views to Deployment view (#1270)
* Adapted GridComponentBuilder#addControllerIdColumn to create a link
* Do not hard-code target link ID prefix
* Encode controller ID
* Introduce HTML encoder for controller IDs
* Remove unused imports
* Enable sorting in tables (#1279)
* provided infrastructure to enable sorting in grids
* Fixed sorting in RolloutGroupTarget
* fixed sorting with pinning and assigned SoftwareModules
* Added sorting for columns createdBy, createdAt, lastModifiedBy and lastModifiedAt
* Adapted status columns to be sortable
* fixed unit tests
* fixing sonar findings
* making Sonar happy
* added testcases for management classes regarding sorting
* added testcases for management classes regarding sorting
* using name for element ids in DOM
* incorporated code review remarks
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* make DdiActionFeedback#time value an optional property (#1283)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Send DMF batch message on thing_created event (#1284)
* send dmf batch message on thing created event
* fix tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Replacing self-managed SonarQube with Sonarcloud (#1286)
* replaced sonar url to use sonarcloud
* changed sonar properties in pom for sonarcloud
* changed sonar properties in pom for sonarcloud
* added sonar plugin to avoid warning regarding relocation of sonar project
* refactoring
* removed sonar plugin from pom.xml, will added to seedjopb build parameter
* specify explicit branch name for sonar (#1289)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Add db migration script of action status code for POSTRESQL databases. (#1291)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Adapted resources to reflect switch to sonarcloud (#1290)
* adapted Readme and resources to reflect sonarcloud
* fixed badges
* Upgraded few dependencies (#1296)
* Upgraded versions of gson, netty-all,logback, jackson-bom dependencies
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixed PR comments
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* removed upgraded versions of gson and netty-codec
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fix Sonar issue (#1301)
* Exclude soft deleted entities from findByRsql result for all entities (#1297)
* exclude soft deleted SMs and SM types from findByRsql result
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* clean up code
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Fix website build with recent Hugo (#1302)
The website currently fails to build with recent versions of Hugo.
Apply some minimal changes to allow the website to build with hugo
v0.93.3.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* docs: fix sandbox URL (#1303)
The sandbox has moved to a new URL some time ago; replace occurrences
with the new URL.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* docs: switch to goldmark markdown handler (#1304)
Abandon no longer supported blackfriday markdown handler and switch to
default goldmark markdown handler. Enabled typographer extension to
handle quotes and dashes.
Website is now building with hugo > 0.100 as well.
Build tested with hugo 0.101.0:
$ docker run --rm -it -v $(pwd):/src:Z -p 1313:1313 klakegg/hugo:0.101.0
server
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* add type name to mgmt api responses (#1298)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Add resource collection /rest/v1/actions to Management REST API (#1299)
* Initial commit
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Added filtering by RSQL
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Support for filtering actions by distribution set, target, rollout
* Added REST docs
* Fixed REST docs
* Introduce a config property which allows to disable the actions endpoint
* Introduce representation mode parameter
* Adapt REST docs
* Incorporate review findings
* Adapt REST docs
* Improve unit tests
* Minor improvements
* Fix REST docs
* Fix REST docs
* Fix PR review findings
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Adding last action status code …
krishna-devolo
added a commit
to devolo/hawkbit
that referenced
this pull request
Jan 17, 2024
* Bump docker setup to 0.3.0M7
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Proxy support for sandbox fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* upgraded Vaadin to 8.12.3
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* How to report vulnerability
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Security chapter added and minor formatting issues fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* adapted DEPENDENCIES list, changed vaadin themes CQ to 8.12.3
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Migration to JUnit5 as default test runtime (#1082)
* Migrate tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* REST docs tests migrated to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Migrated security and UI tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Migrated management tests to JUnit5
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Reflecting changes from JUnit5 migration
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Fix RabbitMQ test detection
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Drop support for JUnit4
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Fix the creation of the Usage Report (#1101)
* Use the forEachTenant method to generate the report for each tenant.
* add a test to verify the functionality of getSystemUsageStatisticsWithTenants
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Introduce new tenant configuration events (#1059)
* Introduce new events that are triggered when changes are made to the tenant configuration.
* Add new events to EventTypes
* Fix DeploymentManagement tests.
* Fix AmqpMessageDispatcherServiceIntegration tests.
* Fix DdiRootControlle test.
* Remove unused imports.
* TenantConfigUpdatedEvent should implement EntityUpdatedEvent
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Feature/remove junit5 leftovers (#1097)
* Migrate JUnit4 leftovers to JUnit5
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix method name typos
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Avoid unnecessary Mockito stubbings
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Replace assertThrows by assertThatExceptionOfType, fix test TODO
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix error for downloading soft deleted artifact binary (#1102)
* download soft deleted artifact throws binary gone exception
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add test and update documentation
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix javadoc
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* test soft deleted artifact has no download link
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Use TargetManagement for the quota related count operation when activating auto assignment instead of performing this operation directly on the repository. (#1108)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix output folder for REST docu tests (#1109)
* Fix output folder for REST docu tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add description to abstract method
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Execute rollouts and auto assignments in the correct user context (#1100)
* Execute rollouts and auto assignments in correct user context
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix PR review findings
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Cleanup usage of lenient
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* UI error handling refactoring (#1106)
* refactored HawkbitUIErrorHandler to delegate error details extraction to external extractor beans
* refactored ui error handling, allowed ui error details extractors to return a list of error details
* added license headers, restructured package structure
* adapted javadocs
* fixed sonar findings
* fixed license header
* added tests for HawkbitUIErrorHandler
* refactored ConstraintViolationErrorExtractor, added test for extractors
* changed UI tests feature to Management UI
* fixed the parent/child error type resolution by ui error details extractor, added test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Refactor AutoAssignExecutor to improve the extensibility (#1110)
* Refactor AutoAssignExecutor to improve the extensibility.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* introduce protected getters
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor auto assign executor. Create deployment requests based on list of controllerIds.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix review findings
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Surround consumer with a try catch block to continue assignment process for other filter. Execute assignment in user context.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix the action status icon "CANCEL_REJECTED" because it was displayed as unknown (#1115)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* ManagementApi: Action does not have property containing rollout name (#1116)
* Mgmt Rest API: Enhance Action payload with rollout properties
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Enhance Mgmt REST API docs
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Minor changes
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Simplified JpaRolloutManagement, moved rollout handling logic to JpaRolloutHandler (#1094)
* introduce RolloutExecutor
* removed unused method
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* Fix test name in order to get executed by surefire (#1117)
* Fix test name in order to get executed by surefire
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix expected group amount for outer query
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Removed flyway downgrade so that spring default is pickedup (#1114)
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Injectable UI target data suppliers (#1123)
* initial proposal for injectible target data provider
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* improved selection of first entity in grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced constructor to explicitely set DataCommunicator for a Grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* made data communicator for target grid injectable
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted size page request to load only one entity for getting total elements, fixed grid duplicates in case lastModified property is the same for targets and rollouts
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* DeleteSupport rethrows the exception to be intercepted by error handlers
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* minor grid refactoring
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted docu for base data providers
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added custom filter data provider, made filter effectively immutable by cloning before data refresh
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* grid returns size directly from data provider instead of data communicator
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* restructured data provider/communicator dependency injection, added injectable data supplier for target filter view grid
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* do not remove confirmation dialog window from UI explicitely
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed sonar, added docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added remote entity events dispatch topic to be fired on deffered events dispatch (#1129)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Remove wrong license header (#1127)
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Set DdiActionFeedback ID deprecated (#1091)
* Deprecate DdiActionFeedback ID
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Add deprecation to FEEDBACK_ACTION_ID in docu
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* PopUp dialog for canceling queued uploads (#1112)
* added cancel dialog for queued uploads
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix PR review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix sonar finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed DashboardMenu navigation
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Consider Target Fields when validating RSQL filters (#1121)
* Removed unnecessary DB queries when editing/validating RSQL query in Target Filter Management (#1023)
Added valid TargetFields to RSQL validation when editing Target Filter.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Corrected visit OrNode implementation.
Changed isValid to receive FieldNameProvider as parameter
Reduced code duplication by moving commonly used utility methods to AbstractFieldNameRSQLVisitor from ValidationRSQLVisitor abd JpqQueryRSQLVisitor
Refactored and extended Unit Tests.
Minor corrections and typos.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Added Maven entry for devolo 2020 copyright header.
Signed-off-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Fix failing unit tests
* # WARNING: head commit changed in the meantime
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix Sonar findings.
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Cleanup
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix PR review findings
* Fix invalid queries in unit tests
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Added test case to create filter with invalid query via Mgmt REST API
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
Co-authored-by: Sergey Gerasimov <sergey.gerasimov@devolo.de>
* Added userinfo endpoint to validate basic auth (#1131)
* Added userinfo endpoint to validate basic auth
* Fixed the bean exception for failing tests
* Added tests for userinfo endpoint with basic auth
* Added the missing license header
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Publish target assign event (#1136)
* Throw the TargetAssignDistributionSetEvent even if there are actions in CANCELING state present. Filter the actions on the receiver side. In this case at the DMF.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix deploymentManagementTest
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Add debug logs and fix tests to verify correct DMF message behaviour
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Extend test case for the DMF in case the cancel is confirmed by the device
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Remove unsued import
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix review findings by filtering the list of targets first before querying the database for distribution set and software module.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* flip list verification logic
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor amqp tests
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* suppressed functional interface sonar issue for MgmtBasicAuthRestApi
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Support case-insensitive RSQL expressions /target filters (#1137)
* Interpret /parse RSQL expressions case insensitive
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Add unit test verifying that RSQL expressions are case insensitive
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Feature/handle amqp fatal errors (#1111)
* Adding support to handle lengthy error msgs more precisely
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Added check at conditionalHandler level and changes assertions in test class
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixed sonar lint issues
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Reverted the change on making class final
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* To trigger the circle-ci build and check
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Addressed last set of PR comments
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixe sonar issue for nullpointer dereference
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Handling null case explicitly
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Make RSQL visitor pluggable via a managed bean (#1145)
* Add a managed bean for a RsqlVisitorFactory
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Fix failing unit tests
* Fix Sonar findings
* Fix PR review findings
* View-scoped event listeners (#1134)
* added UI EntityNotFound error details extractor
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed Target count label to not rely on grid data change events but rather on EntityModified UI events to decide how to react dependand on the event type
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added current view check on entity modified events
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* unsubscribe/resubscribe event listeners on view leave/enter, reselect grid entities on view enter
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed target grid count reset on initial load and after view change
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* re-evaluate filters on Deployment View enter
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added on view enter logic for rest of the views
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced event listener aware layout and view, adapted code accordingly
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed bulk upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added missing docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted software module deselection upon master entity change
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed npe in case master support is not present (Artifact View)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* restructured amqp assignDistributionSetMultipleTimes test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added waiting for the messages to be dispached by test
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Optional controller attributes for THING_CREATED (#1154)
* added optional attributes payload to THING_CREATED DMF message
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added optional attributes unit test for THING_CREATED message handler
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* extended Target interface with getControllerAttributes method, extended DMF message handler integration tests
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* updated hawkbit docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed review findings
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Set key of DistributionSetType and SoftwareModuleType required (#1140)
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Replace NoCountPagingRepository by interface with dedicated findAllWithoutCount (#1146)
* Replace NoCountPagingRepository by enhanced BaseRepository
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add missed withoutcount call in distributionsettype find all
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add missing overrides to NoCountRepository implementation
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Remove need of repository by referencing base class directly in configuration
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Align target queries to only use specifications (#1148)
* Add additional specifications to cover use cases of queries
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Replace reading target queries by spec, use empty spec in default repo calls
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Use correct NonNull annotation
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Added default exists based on spec count to TargetRepository
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Feature/enforce hash validation for uploads (#1158)
* moved artifact duplication check after hash check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added unit tests
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed copyright header
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Feature target type entity (#1162)
* Added Target Type model
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type JPA model
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type repository model classes
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the name entity from Target Type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Refactored the Target Type models
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added the DB migration script and updated the Target Type models
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type in target Mapper
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Changed the target type ID to Long
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added MYSQL DB migration script and removed the deleted column for target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Updated the DB migration script for target table
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added manyToMany reltation between target type and Ds type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added POSTGRESQL DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added MSSQL SERVER DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added DB2 DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing license header and java docs
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added on delete cascade in DB migration script
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target Type specification
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the delete cascade and Added type API
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* fixed API doc build
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type management test
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type events test
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type update and unassign to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added API tests for assigning target type to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing license header
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added missing docs
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed sonar issues
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed license header build issue
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Updated the attribute name to target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed unused error status variable
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target API to assign target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added the tests for assigning target type to target
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the review comments for null check
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fix sonar/repository for target type (#1169)
* fix sonar/repository for target type changes
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* review finding
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Dependency upgrades (#1170)
* Increase jsoup version
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* bumped vaadin/guava/common-io to newest versions
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* substituted deprecated guava create temp dir method
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fix null pointer exception in rsql target field validation test (#1172)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Colour property in Mgmt API response for DS/SM type (#1174)
* Update name SP to hawkbit in api guide adocs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix javadoc class descriptions of existing resource/api classes
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add color property to api response of ds/sw type
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add color property to sw type test data & adapt rest docu
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Add missing property description for "colour" and "deleted"
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Test: max DS Types per TargetType (#1175)
* add dsTypes in targetType quota test
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* README: add mention to Hara and hara-ddiclient (#1173)
Add a mention to the Eclipse Hara project and the hara-ddiclient library
that has been pushed recently to the Eclipse Foundation repositories.
Rework a bit the text to reflect this change.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* Introduce basic functionality for invalidation of distributionsets (#1179)
* Basic DS invalidation functionality
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add checks for valid/complete DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Stop rollouts + auto assignments when invalidating a DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add methods to count AAs + rollouts for invalidation
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Small refactoring for DS management
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add invalidation functionality to REST API
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix update stopped rollouts status
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add various tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Introduce countActionsForInvalidation
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix event tests with incomplete DS
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add H2 migration script
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix action count method
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix REST documentation tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Change flyway version number
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add lock for DS invalidation + adapt tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move concurrency test to own class
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Handle possible InterruptedException
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix concurrency test
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Use one transaction for all invalidations
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add invalidate endpoint to REST docu
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Execute invalidation in transaction when actions are cancelled
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Check that distribution set is valid when editing/creating metadata
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Remove all changes in UI
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Add DB migration files for all databases
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Implement review findings
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move DS invalidation to own class to check permissions for single steps
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Move invalidation count methods to management classes
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Fix failing tests
Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
* Feature invalidation of distribution sets [UI part] (#1176)
* Visualization of action/button invalidate DistributionSet
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* introduced two dialogs to confirm ds invalidation
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed dialog titles appear centered and added manamgement classes
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* retrieving affected entities from repository
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* considered multiselection for invalidating dist sets
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* adapt style and tooltip of invalid distributions in grid
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* showing errors for actions not allowed for invalidate DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* enhanced error message with dist name and version
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added ids to the labels to be used in tests
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added support for overwriting entity specific edit behaviour
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed incorrect label for cancelled action due to invalidation of ds in
a rollout
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed error notification to not show "please try again" for an invalid
DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed Sonar findings
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* remove DS of a copied Rollout in case the DS is invalidated
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* changed icon of RolloutActionStatus in case of stopped Rollout because
of invalidation of DS and DS wasn't yet assigned to target. This is to
distinguish from the case of not assigned DS because of duplicate DS
assignemnt
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Prevent editing Metadata of invalid DS
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* show DS as invalidated in Rollout view
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* incorporated code review remarks
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* invalidated DS should be removed from the list of DS to be invalidated
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed missing code due to merge
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Fixed compile error due to rebase
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* README.md: Add rauc-hawkbit-updater to the list of clients supporting hawkBit (#1181)
Also add the word 'demo' to the python variant to give a hint to not use
this for real-world applications.
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
* Feature mass cancel running actions on ds invalidation (#1177)
* Extend DS invalidation dialog to include mass-cancellation of actions
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
add component id for cancelation type radio buttons
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add infos about ds invalidation to UI documentation;
update UI images; add screenshot about ds invalidation
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review findings
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add link property to invalidation docu
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Put invalidation counts into one object
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add hint to invalidation dialog, that invalidation is unrepeatable
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* disable invalidate button if insufficient permission
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix auto assignment error with insufficient permission
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* implement permissions check for invalidation dialog
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add update_target permission to api doc description
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Feature target with target type in UI (#1178)
* Added the target type combo box to add or update Target in UI
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed NPE for empty target type
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added target type option to target bulk upload
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Target type filter
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Added Named entity mapper for target type UI
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed sonar issues for serialization
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Bulk upload target type combo box
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Feature - TargetType compatibility check (#1180)
* added targettype compatibility check in deployment
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added targettype compatibility for autssignment
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added / fixed tests for auto assignment compatibility check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* adapted rollout creation to use JPA specifications for compatibility checks
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix unit tests and javadoc
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix copyright header
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* replaced validated-DS management calls
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* improved compatibility check in DeploymentManagementTest
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Vaadin security upgrade to 8.14.1 (#1188)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Docu for target type endpoints in Target API (#1185)
* add assign/unassign type endpoints to target api docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix target type creation for api rest docs test
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments: rename tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* adapt test to avoid failing when translated
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix api doc tests in regard to type compatibility (#1191)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Ensure a '.' character is allowed to be used in target filter query for metadata key and attribute name (#1186)
* Adapted code to allow '.' inside of metadata key and attribute names
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* added handling of corner cases
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Adapted metadata and attribute tests to check that dot is allowed
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed documentation
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Allow usage of dot in key names for every map attribute, e.g. also for
metadata in distribution set
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* adapted test key to ensure a dot can be used
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* fixed typo
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* Support keywords in queries (#1193)
* support targettype as keyword in target-queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* support valid as keyword in distributionset-queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* remove targettype.id from filter queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* remove targettype.description from filter queries
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Implement target type CRUD UI operations (#1184)
* implement target type CRUD UI operations
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix licenses
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* code clean up
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* code clean up
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* refactor proxy target type
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* refactor proxy target type
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* update class description
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix review comments
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix sonar issue
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* fix showing assigned ds types
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* remove unused import
Signed-off-by: Virginijus Kandrotas <Virginijus.Kandrotas@bosch.io>
* Specification and BaseRepositotyProvider improvements (#1182)
* Introduce custom base repository factory bean
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Simplify ordered DS service call by using specs
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Annotate getBaseRepoType interface as FunctionalInterface
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Use CustomBaseRepositoryFactory instead of static BaseClass
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Fix license headers
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* Add ordered specification back
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch.io>
* added Insufficient Permissions UI error extractor (#1196)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Adapt UI for target type compatibility check (#1189)
* Added compatibility calls needed for UI
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Adapted UI for target type compatibility checks
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* improved exception handling for incompatibility check
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added & fixed unit tests
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed merged conflicts
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed target type incompatibly specification
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* changed UI behaviour to close assignment popup in case of IncompatibleTargetTypeException
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* added unit test to validate incompatibly specification fix
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review findings
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fix potential null pointer
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Fixed rolloutcopy by adding dsTypeId to ProxyDistributionSetInfo
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* suppressed warning
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Feature target type filter (#1197)
* Added Target type filter with drag and drop support
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Removed the unused enums and target type filter button class
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Resolved merge conflicts
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed java doc issue with the method link in the comment
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed the IN query overflow for target Type assignment
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Fixed Review comments
Signed-off-by: Anand kumar <anand.kumar@bosch-si.com>
* Remove mysql_user and update documentation (#1139)
* Remove mysql_user and update documentation
* MG, udpate based on maintainers feedback
* Remove extra comments for password, already in doc
* fixed compatibility check bug (#1198)
* fixed compatibility check bug & improved testing
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* fixed review finding
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* reduced amount of targets in test
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* mention target type in docu (#1199)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Use an empty AMQP Message body instead of a null value (#1200)
* Artifact Encryption plug point (#1202)
* added ArtifactEncryption interface, injected it into SM creation UI module, added encryption metadata key generation upon SM creation, used encryptor during file upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* add default artifact encryption implementation based on gcm aes algorithm
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed ArtifactEncryptor interface to manage encryption secrets by itself
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* cleaned up stale code, fixed sonar
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed software module encryption within transaction
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added artifact encryption secrets store
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* extended ArtifactEncryption interface to allow decryption, secrets store provides removeSecret, added missing javadocs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* intriduced DbArtifact interface, use EncryptionAwareDbArtifact for artifact decryption during download
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* introduced ArtifactEncryptionService to minimize duplications and unneccessary dependency injections
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* declared ArtifactEncryptionService as a bean
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added persistant encryption flag to software module
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* further adptations for encryption flag persistence
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added ArtifactEncryptionException, fixed encryption check in UI
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added encryption error handling
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added encrypted flag to DDI/DMF, adapted exception handling
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* adapted rest docs
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Add test to verify artifact encryption is not given by default
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Add isEncrypted() to toString() of JpaSoftwareModule, fix typos
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Fix sql migration scripts
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* Calculate encrypted artifact size by subtract encryption size overhead
Signed-off-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* publish upload failed without waiting for interuption during UI file upload
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* upgraded cron utils to 9.1.6
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Co-authored-by: Florian Ruschbaschan <Florian.Ruschbaschan@bosch.io>
* added same origin x-frame-options header security config (#1207)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Make entity object of event optional (#1209)
* explicitly return an optional entity by an event
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix assertions in tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix distribution set tag api doc (#1219)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add license header for Bosch.IO 2022 (#1221)
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* DDI API: /controller/v1/{controllerid}/installedBase/{actionId} (#1220)
* installedBase DDI: initial impl + rest docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* refactor installedBase implementation
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* ddi installed base tests
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* restructure root controller rest docs
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix some java docs and formatting
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* don't add action history message when calling /installedBase
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix test after removing action history message
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix review comments
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* set the JpaControllerManagement constructor public (#1227)
Signed-off-by: Robert Sing <robert.sing@bosch-si.com>
* Updated migration guide to include deprecated property (#1225)
* updated m7 migration to include spring boot deprecated property
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed hawkbit sandbox link
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Feature/fix sonar warnings (#1226)
* Fixed sonar warnings
- "Cognitive Complexity"
- "Do not use replaceAll when not using a regex"
- java:S5869 - Character classes in regular expressions should not contain the same character twice
- Improved bad name
- Typos
- reduced code duplications
- Replaced hand-made wait-utility with Awaitility
- Log messages
- Duplicate code
- Typos
- Removed Thread.sleep, instead relaxed check condition
- Removed use of deprecated API
- Removed use of deprecated API
- Added supress-warnings as I do not see a better way to write the tests
- Removed Thread.sleep / redundant functionality to Awaitility
- Fixed other warnings (use isZero, isEmpty, hasToString)
- Removed/Reduced duplicate code
- Added generics
- Fixed asserts
- removed: field.setAccessible(true) actually should not be needed for public static fields!
- Too long constructor passes arguments in wrong order - how surprisingly...
- Clean-up use of varargs arguments
- Fixed regex
- Fixed typos and other minor stuff
- Making public constructors protected in abstract classes
- Swapped expected and asserted argument
- volatile not enough for syncing threads
- volatile not enough for syncing threads
- out-commented code
- Made regex not-greedy, added tests for verification
- Avoid exposure of thread-local member var
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixed Sonar warnings
* License header fix
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* License header fix #2
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing review findings
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing tests
- Fixed '&' usage in javadoc and typos
- Fixing some warnings
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Feature/speedup quota tests (#1125)
* reduce the number of created entities in tests
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed tests
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed review findings
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* merged master
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* adapted target count
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed review findings
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed RolloutManagementTest
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* fixed flaky test ConcurrentDistributionSetInvalidationTest
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch.io>
* UI deep-linking for targets (#1230)
* added target deeplinking through url param
* populate search irregardless of target existence
* adapted view state paramater evaluation flow
* fixed review comments
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Fix installedBase link in DDI base resource (#1232)
* add test for installedBase bug
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* fix for test scenario I
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add another test scenario for installedbase bug
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* add fix for scenario 2a+b
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
* Optimize UI queries (#1234)
* first iteration of query optimization for target and distribution set
* fixed type distribution set filter
* adapted all ui dataproviders to use repository count
* adapted test to not check target attributes within search query
* unified search behaviuor for ds and sm
* removed unneccessary count queries for some mgmt calls
* removed unneccessary type id proprty from ProxyDistributionSetInfo to minimize lazy fetches
* refactored mgmt classes
* removed duplication of name version filter
* fixed copy rollout compatibility check
* cleaned-up management left overs
* added index to rollouts table on tenant/status queries
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Fix overdue timestamp calculation permission (#1235)
* fixed overdue timestamp calculation permission error
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* changed method visibility
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* upgrade spring framework to 5.2.20 (#1243)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Extend event for entity events (#1250)
* Extend event information by it's first interface class and improve constructing the event by providing the directly only.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Check if entity interface is assignable from TenantAwareBaseEntity.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* improved debug logs for autoassignment (#1253)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Avoid using RegexRequestMatcher due to [CVE-2022-22978] (#1258)
* Use ant instead of regex matcher.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* fix ant matcher
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Do some cleanup and revert unnecessary changes.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Improve target management (#1260)
* Fix join type for targets with their assignedDs
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Override saveAll method and make use of it in the JpaTargetManagement
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Use unmodifiable list and flip transactional logic
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Initialize new list instead of an unmodifiable list.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix testdata factory
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Calculate target count asynchronously (#1263)
* first prototype
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* moved asynchrinous count caclucation to abstract footer support
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* added asynchronous count details calculation
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* fixed typo
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Provide API for auto assignment check for specific device (#1262)
* Extend the auto assign executor to execute a auto assignment check for a specific device.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* add tests and handle exceptions
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add unit test
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add Copyright header
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix Copyright header
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add authorization
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* fix exception handling and authorization
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* renaming
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Rename auto assignment functions
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Stefan Klotz <stefan.klotz@bosch.io>
* Make custom target filter table expandable (#1267)
* initial draft to maximize custom target filer table for better UX in case of long keys/names
* Set correct maximize icon identifier and fix problem with wrong db table structure.
* Remove unnecessary local variable.
* Fix db migration scripts
* Fix losing the target tag table when mac and minimizing target table.
* fixed minor styling, removed duplication
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* add SystemSecurityContext (#1269)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* changed cors configuration bean definition to be reusable under different routes (#1272)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Dmf batch support changes. (#1273)
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Update hawkbit-dmf/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/integration/AmqpMessageDispatcherServiceIntegrationTest.java
Co-authored-by: Bondar Bogdan <36962546+bogdan-bondar@users.noreply.github.com>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement single batch message instead of multiple messages for assigment on multiple targets. Added system property to switch on/off.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
* Dmf batch support changes. Implement code review comments.
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Co-authored-by: Bondar Bogdan <36962546+bogdan-bondar@users.noreply.github.com>
* Update jsoup (#1276)
* upgraded jsoup to 1.15.3
* removed deprecated safe html annotation
* added own valid string jsoup validator, disabled hibernate parallel method declaration constraint
* adapted valid string validator
* static method
* return invalid value in case of processing exception
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Feature/java11 build (#1280)
* hawkBit on Java 11
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
* Preparing java 11 build
- Update eclipse-link maven plugin dependencies
- Fixing warnings, adopt to java-11 style
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Preparing java 11 build
- Fixing warnings, adapt to java-11 style
- Added since to deprecated
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing sonar warnings
- removed deprecated API
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Fixing sonar warnings & failing test
- Added suppressWarning
- added WithSpringAuthorityRule to clean-up listener
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Compile warnings
- Test if final causes issues in tests
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Removed deprecated code
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Reverted changes
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Removed final as this causes invalid reflective access exceptions
- The eclipselink generated classes seem to modify the field directly
- update plugin version
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
* Upgrade eclipselink from 2.7.9 to 2.7.10
* Remove @deprecated endpoints from MgmtTargetTagResource
* Remove dependencies already defined in eclipselink-maven-plugin
* Try eclipselink 2.7.11-RC1
* Set project encoding to UTF-8
* Upgrade surefire and failsafe plugins to 3.0.0-M7
* Try fixed string instead of a random generated one
* Replace JsonBuilder by Jackson ObjectMapper usage
* Use JsonBuilder again
* Use APPLICATION_JSON_UTF8 instead of APPLICATION_JSON
* Try to replace com.vaadin.external.google:android-json by org.json:json
* Add debugging outputs
* Improve debugging outputs
* Improve debugging outputs
* Use Jackson instead of JsonBuilder
* Use Jackson instead of JsonBuilder 2nd part
* Use Spring json dependency
* Use eclipselink 2.7.11
* Fix RootControllerDocumentationTest
* Improve helper methods of AbstractDDiApiIntegrationTest
* Upgrade SpringBoot and SpringCloud versions
* Improve deprecation notice for 0.3.0M8
* Fix BaseAmqpServiceTest
* Fix SpecificationsBuilderTest
* Removed deprecated code
* Define maven-enforcer-plugin version
* Remove com.google.code.findbugs.jsr305
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Update circleci image to openjdk:openjdk:11.0.13-jdk-buster
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Fix javadoc generation and license check
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
* Fix review findings
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>
Signed-off-by: Florian Ruschbaschan <florian.ruschbaschan@bosch.io>
Co-authored-by: Dominic Schabel <dominic.schabel@bosch.io>
Co-authored-by: Peter Vigier <Peter.Vigier@bosch.io>
Co-authored-by: Markus Block <markus.block@bosch-si.com>
* Introduce action status scoped custom code (#1277)
* Allow providing a custom code with an action status feedback to give more fine grained device specific details.
* Add ddi rest docs for new optional status code value.
* Provide new code value via mgmt api. Fix review findings.
* Fix failing tests
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Stefan Behl <stefan.behl@bosch.io>
* Adapt cancel flow (#1274)
* Adapt assignment events to communicate mass cancel operations within one event.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix edge cases identified by test failures. Adapt tests and reduce amount of published cancel events.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix license header
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Refactor visibility of methods in assignment strategy classes. Avoid having empty action status messages.
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Fix api docs
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Co-authored-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Remove unused (public) methods from JsonBuilder (#1281)
* Provide target quicklinks from Target Filters and Rollout views to Deployment view (#1270)
* Adapted GridComponentBuilder#addControllerIdColumn to create a link
* Do not hard-code target link ID prefix
* Encode controller ID
* Introduce HTML encoder for controller IDs
* Remove unused imports
* Enable sorting in tables (#1279)
* provided infrastructure to enable sorting in grids
* Fixed sorting in RolloutGroupTarget
* fixed sorting with pinning and assigned SoftwareModules
* Added sorting for columns createdBy, createdAt, lastModifiedBy and lastModifiedAt
* Adapted status columns to be sortable
* fixed unit tests
* fixing sonar findings
* making Sonar happy
* added testcases for management classes regarding sorting
* added testcases for management classes regarding sorting
* using name for element ids in DOM
* incorporated code review remarks
Signed-off-by: Markus Block <markus.block@bosch-si.com>
* make DdiActionFeedback#time value an optional property (#1283)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Send DMF batch message on thing_created event (#1284)
* send dmf batch message on thing created event
* fix tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Replacing self-managed SonarQube with Sonarcloud (#1286)
* replaced sonar url to use sonarcloud
* changed sonar properties in pom for sonarcloud
* changed sonar properties in pom for sonarcloud
* added sonar plugin to avoid warning regarding relocation of sonar project
* refactoring
* removed sonar plugin from pom.xml, will added to seedjopb build parameter
* specify explicit branch name for sonar (#1289)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
* Add db migration script of action status code for POSTRESQL databases. (#1291)
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
Signed-off-by: Michael Herdt <Michael.Herdt@bosch.io>
* Adapted resources to reflect switch to sonarcloud (#1290)
* adapted Readme and resources to reflect sonarcloud
* fixed badges
* Upgraded few dependencies (#1296)
* Upgraded versions of gson, netty-all,logback, jackson-bom dependencies
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fixed PR comments
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* removed upgraded versions of gson and netty-codec
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
* Fix Sonar issue (#1301)
* Exclude soft deleted entities from findByRsql result for all entities (#1297)
* exclude soft deleted SMs and SM types from findByRsql result
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* add tests
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* clean up code
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Fix website build with recent Hugo (#1302)
The website currently fails to build with recent versions of Hugo.
Apply some minimal changes to allow the website to build with hugo
v0.93.3.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* docs: fix sandbox URL (#1303)
The sandbox has moved to a new URL some time ago; replace occurrences
with the new URL.
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* docs: switch to goldmark markdown handler (#1304)
Abandon no longer supported blackfriday markdown handler and switch to
default goldmark markdown handler. Enabled typographer extension to
handle quotes and dashes.
Website is now building with hugo > 0.100 as well.
Build tested with hugo 0.101.0:
$ docker run --rm -it -v $(pwd):/src:Z -p 1313:1313 klakegg/hugo:0.101.0
server
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
* add type name to mgmt api responses (#1298)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
* Add resource collection /rest/v1/actions to Management REST API (#1299)
* Initial commit
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Added filtering by RSQL
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Support for filtering actions by distribution set, target, rollout
* Added REST docs
* Fixed REST docs
* Introduce a config property which allows to disable the actions endpoint
* Introduce representation mode parameter
* Adapt REST docs
* Incorporate review findings
* Adapt REST docs
* Improve unit tests
* Minor improvements
* Fix REST docs
* Fix REST docs
* Fix PR review findings
Signed-off-by: Stefan Behl <stefan.behl@bosch.io>
* Adding last action status code in view Rollout…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR improves specification compatibility by replacing the
CriteriaBuilderapproach of the ordered target management query with a spec based approach. In addition it enhances the flexibility of the base repository by using a JpaRepositoryFactoryBean that loads BaseRepositories dynamically instead of a fixed BaseRepository.