Closed
Conversation
ekrylovich
commented
Apr 11, 2018
|
|
||
| private boolean comparePortMapping(List<PortMapping> elementPorts, Map<ExposedPort, Ports.Binding[]> portBindings) { | ||
| private boolean isPortMappingListsEqual(List<PortMapping> elementPorts, List<PortMapping> containerPorts) { | ||
| return elementPorts.size() == containerPorts.size() |
ekrylovich
commented
Apr 11, 2018
| } | ||
| ElementStatus status = docker.getElementStatus(container.getId()); | ||
| if (status.getStatus() == ElementState.REMOVED) { | ||
| latestElements.remove(element); |
Contributor
Author
There was a problem hiding this comment.
reverse engineering
elukashick
reviewed
Apr 13, 2018
| if (containerState != null) { | ||
| if (containerState.getStartedAt() != null) { | ||
| result.setStartTime(getStartedTime(containerState.getStartedAt())); | ||
| ContainerState status = inspectInfo.getState(); |
Contributor
There was a problem hiding this comment.
maybe rename to containerState
elukashick
reviewed
Apr 13, 2018
| * @param containerId - id of {@link Element} | ||
| * @return boolean true if exists and false in other case | ||
| */ | ||
| public boolean hasContainerWithContainerId(String containerId) { |
Contributor
Author
There was a problem hiding this comment.
look it more deeply
ekrylovich
commented
Apr 13, 2018
| long containerStartedAt = docker.getContainerStartedAt(container.getId()); | ||
| if (!running || elementLastModified > containerStartedAt || !docker.isElementAndContainerEquals(container.getId(), element)) { | ||
| addTask(new ContainerTask(UPDATE, element.getElementId())); | ||
| if (status.getStatus() != ElementState.REMOVED) { |
Contributor
Author
There was a problem hiding this comment.
status.getStatus
ekrylovich
commented
Apr 13, 2018
| }; | ||
|
|
||
| private boolean shouldContainerBeUpdated(ElementStatus status, String containerId, Element element) { | ||
| boolean isNotRunning = !(ElementState.RUNNING == status.getStatus()); |
dbusel
pushed a commit
that referenced
this pull request
May 8, 2018
send system info from HAL to Controller
emirhandurmus
added a commit
to Datasance/iofog-agent
that referenced
this pull request
Mar 24, 2026
agent directory and file permissions fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.