Conversation
| @@ -132,8 +130,8 @@ public void setVolumeMappings(List<VolumeMapping> volumeMappings) { | |||
|
|
|||
| @Override | |||
| public boolean equals(Object e) { | |||
There was a problem hiding this comment.
perhaps it's preferable to write like this:
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
Element element = (Element) o;
return Objects.equal(elementId, element.elementId);
There was a problem hiding this comment.
Josh Bloch favors my approach:
The reason that I favor the instanceof approach is that when you use the getClass approach, you have the restriction that objects are only equal to other objects of the same class, the same run time type. If you extend a class and add a couple of innocuous methods to it, then check to see whether some object of the subclass is equal to an object of the super class, even if the objects are equal in all important aspects, you will get the surprising answer that they aren't equal. In fact, this violates a strict interpretation of the Liskov substitution principle, and can lead to very surprising behavior. In Java, it's particularly important because most of the collections (HashTable, etc.) are based on the equals method. If you put a member of the super class in a hash table as the key and then look it up using a subclass instance, you won't find it, because they are not equal.
| @@ -49,4 +49,10 @@ public boolean equals(Object other) { | |||
| return this.outside.equals(o.outside) && this.inside.equals(o.inside); | |||
There was a problem hiding this comment.
the same deal with 'equals' here
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { |
| } | ||
| params = params.trim() + "\"}"; | ||
| byte[] postData = params.trim().getBytes(StandardCharsets.UTF_8); | ||
| params = new StringBuilder(params.toString().trim() + "\"}"); |
| throw new Exception(" Id not found "); | ||
| if (jsonObject.getString("id").equals(null) || jsonObject.getString("id").trim().equals("")) | ||
| if (!jsonObject.containsKey("id") || | ||
| jsonObject.getString("id").equals("null") || |
There was a problem hiding this comment.
"null " in forward
min dockerApiVersion version adjusted to be compatible with embedded…
3 participants
No description provided.