Pre-release merge #531
Merged
Pre-release merge #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#529) * feat(catalog): allow update catalog item image without regular fields + fix createOrUpdate for catalogItemManager (create didn't work) Closes ENG-622 * feat(catalog): allow update catalog item image without regular fields + fix tests Closes ENG-622
* feat(cli): add correct validation for cli
+ args parsing using Mar of <arg, values>
+ throw error if value for number arg not provided or string was provided:
`--number_arg string` or `--number_arg`
- validation of number type (integer/float) because there is no info about type in help
* feat(cli): add correct validation for cli
+ float/integer validation
+- number -> float/integer in cli help
* feat(cli): add correct validation for cli
+- correct regexp for parsing cli
* feat(cli): add correct validation for cli
+- correct Integer and Float types
+- fix some problems
Closes ENG-621
dbusel
added a commit
that referenced
this pull request
Feb 7, 2019
* Master - Develop merge (#520) * Issues with update/delete system microservices CLI and API (#521) * fix cli issues with /update/delete system microservices * fix according team solution * Update default.json * Update development.json * Update production.json * fix remove of not running system microservices * fix formating after merge from develop * fix code review comment * fix code review comment * feat(tracking): add tracking for some events (ENG-429) * feat(core) added seed with catalog item for logging microservice (ENG-194) * bug(fix): improve validation for parameters with type "number" (ENG-546) (#525) * bug(fix): improve validation for parameters with type "number" (ENG-546) * bug(fix): fix for types (ENG-546) * bug(fix): seconf fix type float (ENG-546) * feat(tracking): add tracking for some events (#527) fix data format Closes ENG-261 * Add Ian's improvements: integration for slack (#522) * add Ian's improvements * update to try to fix the TravisCI build * Update .travis.yml * feat(microservices): allow to delete system microservies via cli (#528) Closes ENG-534 * feat(tracking): create temp db for tests (#524) * feat(tracking): create temp db for tests + db backups + refactoring Closes ENG-556 * feat(tracking): create temp db for tests + refactoring + single api script + possibility to call one script from another + postman test start and stop controller api by itself - delete stop and start commands from travis Closes ENG-556 * feat(tracking): create temp db for tests + fix travis. start server on dev_deploy and pre_release Closes ENG-556 * feat(SCRIPTS): create temp db for tests + correct vars' names Closes ENG-556 * pre release version 1.0.36 * Update .travis.yml * Pre-release merge (#531) * feat(catalog): allow update catalog item image without regular fields (#529) * feat(catalog): allow update catalog item image without regular fields + fix createOrUpdate for catalogItemManager (create didn't work) Closes ENG-622 * feat(catalog): allow update catalog item image without regular fields + fix tests Closes ENG-622 * Maksimchepelev/fetaure cli validation ENG-546 (#530) * feat(cli): add correct validation for cli + args parsing using Mar of <arg, values> + throw error if value for number arg not provided or string was provided: `--number_arg string` or `--number_arg` - validation of number type (integer/float) because there is no info about type in help * feat(cli): add correct validation for cli + float/integer validation +- number -> float/integer in cli help * feat(cli): add correct validation for cli +- correct regexp for parsing cli * feat(cli): add correct validation for cli +- correct Integer and Float types +- fix some problems Closes ENG-621 * fixes for release (#533) * feat(catalog): allow update catalog item image without regular fields (#529) * feat(catalog): allow update catalog item image without regular fields + fix createOrUpdate for catalogItemManager (create didn't work) Closes ENG-622 * feat(catalog): allow update catalog item image without regular fields + fix tests Closes ENG-622 * Maksimchepelev/fetaure cli validation ENG-546 (#530) * feat(cli): add correct validation for cli + args parsing using Mar of <arg, values> + throw error if value for number arg not provided or string was provided: `--number_arg string` or `--number_arg` - validation of number type (integer/float) because there is no info about type in help * feat(cli): add correct validation for cli + float/integer validation +- number -> float/integer in cli help * feat(cli): add correct validation for cli +- correct regexp for parsing cli * feat(cli): add correct validation for cli +- correct Integer and Float types +- fix some problems Closes ENG-621 * Maksimchepelev/bugs (#532) * feat(cli): delete unnecessary output - delete status code and port mapping id output Closes ENG-621 * fix(microservice): add internal port validation in remove port mapping Closes ENG-623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description