Maksimchepelev/fetature logging eng 557 #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ separate destination for different log levels: * verbose, debug, silly only to file * info, warn, error to console and file Closes ENG-557
+ json format Closes ENG-557
+ make logs' properties sorted the same way: [level, timestamp, message, args] Closes ENG-557
- disable express logs (comment app.use(morgan())) Closes ENG-557
+ add nested object support for logger args Closes ENG-557
+ cliRes cliReq apiRes apiReq logging levels Closes ENG-557
+ add cli logs for request and response Closes ENG-557
+ add api logs for request and response Closes ENG-557
dbusel
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description