ESlint errors fix #555
Merged
ESlint errors fix #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* arguments -> ...args in declaration * some small style fixes
baghbidi
suggested changes
Feb 21, 2019
Contributor
baghbidi
left a comment
baghbidi
left a comment
There was a problem hiding this comment.
Need to use spread operator (...) on all args. (which is called Rest Parameters), other than that it looks good
dbusel
added a commit
that referenced
this pull request
Feb 22, 2019
* re-enabling linting * ESlint errors fix (#555) * feat(core) default configs for microservices progress (ENG-196) (#545) * fix lint errors in test folder * fix lint errors in scripts folder * fix lint errors in src folder * feat(style): fix lint errors (#553) * arguments -> ...args in declaration * some small style fixes * fix lint errors while merge with develop
dbusel
pushed a commit
that referenced
this pull request
Feb 25, 2019
* bug(fix): Change order of controller's log files (ENG-584) * feat(cli): fix help (ENG-742) * bug(fix): Change order of controller's log files update postinstall script for version less 1.0.37 (ENG-584) (#548) * feat(config): add default config values in js code (#549) * feat(config): add dafault config values in js code increase stability. this allow to work without any config fix memory leack problem in jobs Closes ENG-630 * feat(config): add dafault config values in js code fix formatting Closes ENG-630 * 9!!! * bug(fix) fixing seeds fogTypeId rollback (ENG-559) * feat(logger): fix logger rotation (#557) * bug(fix) updated libs with high vulnerabilities based on npm audit (ENG-691) (#556) * bug(fix) fixing private registries (ENG-745) (#558) * feat(cli): fix string validation in cli (#559) * bug(fix) filtering agent microservices without images (ENG-560) (#560) * bug(fix) filtering agent microservices without images (ENG-560) * cleanup * enable linting (#561) * re-enabling linting * ESlint errors fix (#555) * feat(core) default configs for microservices progress (ENG-196) (#545) * fix lint errors in test folder * fix lint errors in scripts folder * fix lint errors in src folder * feat(style): fix lint errors (#553) * arguments -> ...args in declaration * some small style fixes * fix lint errors while merge with develop * hot fix * Update index.js * Update index.js * Update postinstall.js * fix lint errors * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description