Skip to content

bug(fix) fixing private registries (ENG-745) #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019
Merged

bug(fix) fixing private registries (ENG-745) #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sequelize/managers/microservice-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class MicroserviceManager extends BaseManager {
model: Registry,
as: 'registry',
required: true,
attributes: ['url']
attributes: ['id']
}
],
attributes: ['picture', 'category']
Expand Down
2 changes: 1 addition & 1 deletion src/services/agent-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const getAgentMicroservices = async function (fog, transaction) {
rebuild: microservice.rebuild,
rootHostAccess: microservice.rootHostAccess,
logSize: microservice.logSize,
registryUrl: microservice.catalogItem.registry.url,
registryId: microservice.catalogItem.registry.id,
portMappings: microservice.ports,
volumeMappings: microservice.volumeMappings,
imageSnapshot: microservice.imageSnapshot,
Expand Down
6 changes: 3 additions & 3 deletions test/src/services/agent-service.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ describe('Agent Service', () => {
}
],
registry: {
url: 'testUrl'
id: 10
}
},
routes: routes
Expand All @@ -769,7 +769,7 @@ describe('Agent Service', () => {
delete: false,
deleteWithCleanup: false,
routes: routes,
registryUrl: 'testUrl'
registryId: 10
}]
};

Expand Down Expand Up @@ -872,7 +872,7 @@ describe('Agent Service', () => {
delete: false,
deleteWithCleanup: false,
routes: routes,
registryUrl: 'testUrl'
registryId: 10
};

const microserviceResponse = {
Expand Down