Skip to content

bug(fix) microservice update removes config (ENG-843) #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019
Merged

bug(fix) microservice update removes config (ENG-843) #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sequelize/models/microservice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = (sequelize, DataTypes) => {
config: {
type: DataTypes.TEXT,
field: 'config',
defaultValue: '',
defaultValue: '{}',
},
name: {
type: DataTypes.TEXT,
Expand Down
8 changes: 4 additions & 4 deletions src/services/microservices-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,11 @@ async function listVolumeMappings(microserviceUuid, user, isCLI, transaction) {
// this function works with escape and unescape config, in case of unescaped config, the first split will not work,
// but the second will work
function _validateMicroserviceConfig(config) {
if (config === undefined || config === '{}') {
return '{}'
let result
if (config) {
result = config.split('\\"').join('"').split('"').join('\"')
}

return config.split('\\"').join('"').split('"').join('\"')
return result
}

async function _createMicroservice(microserviceData, user, isCLI, transaction) {
Expand Down