Skip to content

I20200516-0600

I20200516-0600: Bug 560431 - convert to enhanced for loop may cause build time warnings
@jjohnstn jjohnstn tagged this 15 May 18:29 
- add new cleanup preference in CleanUpConstants:
  CONTROL_STATMENTS_CONVERT_FOR_LOOP_ONLY_IF_LOOP_VAR_USED
- default new cleanup preference to false in CleanUpConstantsOptions
- add new messages for new preference
- add new preference as slave to enhanced for loop conversion in
  CodeStyleTabPage
- pass new preference to ConvertLoopFix and ConvertLoopFixCore and
  ultimately to ConvertForLoopOperation and ConvertIterableLoopOperation
- add new code to ConvertForLoopOperation and
  ConvertIterableLoopOperation to verify the loop variable gets used
  if the new preference is true
- add new tests to CleanUpTest1d5 to verify loops that don't use
  loop variable are not converted when preference is set
- remove ignored test for Bug 560431 from ConvertForLoopQuickFixTest

Change-Id: I0476bf223f0f76fcd112aead4c29ef358942fb52
Assets 2
Loading