Issue 8 - getInterpretedSpecVersion inconsistent with javadoc#9
Merged
nitind merged 4 commits intoeclipse-jeetools:masterfrom Apr 8, 2024
Conversation
…rovider to use the highest version when nothing else is known (eclipse-jeetools#8) Assuming the highest version is the expected behaviour according to the JavaDoc. It is also the the behaviour that was present in 487b0b3 before the changes for Jakarta EE 10 in 9788800 . The changes to support Jakarta EE 10 clamped the version at EE 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #8 by always using the highest EE version. This is the previous behaviour before the changes to support Jakarta EE 10.
I think this behaviour is also correct across the Java EE/Jakarta EE divide. The EAR import wizard will use a runtime for choosing the correct version if selected in the wizard. This should prevent problems with Java EE users getting a Jakarta EE version.