This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Conversation
- add missing hashCode() - fix equals() - make explicit the tag length and limit to 2 the tag size
…Tag class - addition of a first check dedicated to Calypso requirements for TLV analysis (unit test)
- remove superfluous throws declarations - make final some fields - remove dangling comments (changes to block comments) - add Javadoc @deprecated tag - fix double cast issue (time measuring) - fix exception logging (logger is able to log exceptions), remove printStackTrace - fix naming of fields
- fix int promotion is OpenSession32RespPars - add "synchronized" to match the parent class implementation
- reorder final static keywords
- reorder public abstract, private static, public static keywords
- provide parametrized type when necessary (there are still a few)
- disable warnings in PC/SC (uses reflexivity)
- create ProxyElement - delete Nameable.java and Configurable.java - move AbstractSeProxyComponent in plugin package, make private-package
- make the increase/decrease anticipated responses correct
- now starting at 0 as in previous versions
pterr
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of fixes related to SonarQube's remarks