This repository was archived by the owner on Sep 13, 2022. It is now read-only.
refact: KEYP-371 Mark SAM manager classes as deprecated #492
Merged
Conversation
… to a separate package
pterr
approved these changes
Dec 16, 2020
brice-ruppen
pushed a commit
that referenced
this pull request
Dec 17, 2020
… to a separate package (#492)
ocfmem
added a commit
that referenced
this pull request
Dec 17, 2020
* Release 0.9.0 to master (#408) * feat: KEYP-12/245 resolve issues raised by SonarQube - fix int promotion is OpenSession32RespPars - add "synchronized" to match the parent class implementation * (merge) change default parameter visibility * feat: KEYP-12/245 resolve issues raised by SonarQube - reorder final static keywords * (merge) spotless * (merge) fix mock * feat: KEYP-12/245 resolve issues raised by SonarQube - reorder public abstract, private static, public static keywords * feat: KEYP-12/245 resolve issues raised by SonarQube - provide parametrized type when necessary (there are still a few) * feat: KEYP-12/245 fix spotless * feat: KEYP-12/245 resolve issues raised by SonarQube - disable warnings in PC/SC (uses reflexivity) * feat: KEYP-12/245 merge Nameable and Configurable into ProxyElement - create ProxyElement - delete Nameable.java and Configurable.java - move AbstractSeProxyComponent in plugin package, make private-package * feat: KEYP-12/248 fix close session issue - make the increase/decrease anticipated responses correct * feat: KEYP-12/249 fix SeSelection index - now starting at 0 as in previous versions * (merge) fix example version * (merge) fix samResource manager const * (merge) spotless * (merge) fix example spotless * Refact: SeProxyService.registerPlugin now returns registered plugin. Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * feat: KEYP-12: add method "fillContent" to CalypsoPo (for WriteRecord command) Signed-off-by: Andrei Cristea <andrei.cristea019@gmail.com> * feat: KEYP-12/250-251 refactor selectors - remove IsoAid inner class from SeSelector.AidSelector - apply the builder pattern to all selectors (SeSelector, PoSelector, SamSelector, SamIdentifier) - update unit tests and examples * feat: KEYP-12/250-251 wip * feat: KEYP-12/250-251 finalize selector classes - changes to builder pattern with inheritance - update javadoc * feat: KEYP-12/250-251 refactor selectors - remove IsoAid inner class from SeSelector.AidSelector - apply the builder pattern to all selectors (SeSelector, PoSelector, SamSelector, SamIdentifier) - update unit tests and examples * feat: KEYP-12/250-251 update Android examples with the new selectors APIs * Refact: KEYP-108: * KeypleReaderException is now thrown by all class implementing AbstractPlugin * Removed KeypleRuntimeException from AbstractPlugin constructor * AbstractPluginFactory us now an interface (to be renamed!) * All exceptions in getPluginInstances() implementations are now wrapped into KeyplePluginInstanciationException. Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: KEYP-108: Renammed AbstractPluginFactory to PluginFactory Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * feat: KEYP-12/250-251 changes the way selectors are used in the examples - remove prefixes SeSelector and PoSelector whenever possible * Fix: Tests issues Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: Improved singleton parter of PcscPluginImpl Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: Code review feedback Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: Typo Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * fix: KEYP-290 correction of an NPE generated at the opening of the session in rev 2.4 - when parsing the answer to the open secure session command an empty array is created for rev 2.4 if no data is available (no record read) * feat: KEYP-12/102 fix minor Sonar's advice * feat: KEYP-12/102-139 improve PoTransactionTest - use constant strings - remove unnecessary commands * feat: KEYP-12/102-139 fix protocol issue in SAM selection - * feat: KEYP-12/102-139 improve PoTransactionTest - more constants defined - general clean up * feat: KEYP-12/102-139 add new unit tests - AbstractMatchingSe, AbstractSeSelectionRequest, PoSelectionRequest, SelectionsResult classes * feat: KEYP-12/102-139 remove unreferenced classes * feat: KEYP-12/102-139 wip add unit tests * feat: KEYP-12/102-139 add assertj dependency to keyple-core * feat: KEYP-12/102-139 add and update unit tests * feat: KEYP-12/102-139 fix a conversion issue in Increase/Decrease parsers * feat: KEYP-12/102-139 remove unreferenced class * feat: KEYP-12/102-139 add and update SAM commands unit tests * feat: KEYP-12/102-139 fix some issues in SAM cmd revealed by the new unit tests * feat: KEYP-12/102-139 change default SAM revision to C1 * feat: KEYP-12/102-139 remove unnecessary param checks and old TODOs * feat: KEYP-12/102-139 update CalypsoSam SamSelectionRequest unit tests * feat: KEYP-12/102-139 remove commented code * feat: KEYP-12/102-139 open session unit tests (wip) * feat: KEYP-12/102-139 fix a conversion issue raised by a new unit test * feat: KEYP-12/102-139 change SeSelector access modifiers to private * feat: KEYP-12/292 make CalypsoPo and CalypsoSam non-final, their methods final * feat: KEYP-12/102-139 fix issues in open secure session response rev10 * feat: KEYP-12/102-139 complete redesign of openSessionRespPars unit tests * feat: KEYP-12/292 make PoSelectionRequest non-final * fix: KEYP-293 add utf-8 encoding setting for Javadoc - build.gradle, task javadocJar * fix: KEYP-293 remove utf-8 encoding setting for Javadoc from Android/Dokka config * feat: KEYP-12/295 make KeypleException extend RuntimeException * feat: KEYP-12/295 remove unnecessary 'throws Keyple*Exception' from keyple-core * feat: KEYP-12/295 remove unnecessary 'throws Keyple*Exception' from keyple-plugin-pcsc - update Javadoc * feat: KEYP-12/295 remove unnecessary 'throws Keyple*Exception' from keyple-plugin-stub - update Javadoc * feat: KEYP-12/295 remove unnecessary 'throws Keyple*Exception' from keyple-plugin-remotese - update Javadoc * feat: KEYP-12/295 remove unnecessary 'throws (Keyple|Calypso)*Exception' from keyple-calypso - update Javadoc * feat: KEYP-12/295 remove unnecessary 'throws (Keyple|Calypso)*Exception' from keyple-example - update Javadoc * Jenkinsfile: kill daemons to lower memory usage Add keyple_version to plugin build Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> * feat: KEYP-12/295 remove unnecessary 'throws (Keyple|Calypso)*Exception' from interfaces and abstract classes - update Javadoc * feat: KEYP-12/295 remove unnecessary 'throws (Keyple|Calypso)*Exception' (more) - update Javadoc * Refact: KEYP-201: Code refactoring, still some test to fix. Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: Few test fixes Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: Spotless Issue Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: Remove with key in AbstractThreadedObservablePlugin.java, improved SamResourceManagerDefault constructor, spotless fixes in Android Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: Spotless alert Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fixed: SamResourceManagerDefaultTest.java Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: AndroidNfcPluginImplTest.kt Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fixed: Build issue with ReaderUtilities.java Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fixed: SeProxyService was returning a second instance of stub pligun Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: SeProxyService.getPluginInstance is now SeProxyService.getPlugin Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix: MAp key of PCSC reader Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * feat: KEYP-12 update release notes (wip) * feat: KEYP-12 update release notes - add keyple-java-core and keyple-java-calypso changes * feat: KEYP-12,298 fills some gaps in the API and corrects small deviations from the documentation * feat: KEYP-12,298 update unit tests * fix: KEYP-12,201 change map and fix unit test - the map of readers in AbstractPlugin is set to ConcurrentHashMap - correction in a remote se unit test using this map * fix: KEYP-12,201 replace PoResource - all occurrences of PoResource are replaced by SeResource<CalypsoPo> - PoResource.java is deleted * fix: KEYP-12,201 replace SamResource - a new inner class named ManagedSamResource is created in SamResourceManager to handle the occupation status of the SeResource<CalypsoSam> in a dedicated Map. - all other occurrences of SamResource are replaced by SeResource<CalypsoSam> - SamResource.java is deleted * fix: KEYP-12,201 replace PoResource (Android) * fix: KEYP-12,201 make SeResource final * Update release notes * Update ReleaseNotes.md * fix: KEYP-12,201 revert temporarily SeResource to non final * Reactivate keyple gradle plugin in android projects Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> * feat: KEYP-12-23 addition of a first draft of features related to the PIN code * feat: KEYP-12-23 update PoSecuritySettings related to PIN transmission * feat: KEYP-12-23 spotless * feat: KEYP-23 adds PIN verification functions in PoTransaction * feat: KEYP-23 adds PIN verification example (usecase 6) * feat: KEYP-23 updates Verify PIN process, adds Javadoc * feat: KEYP-23 add check PIN status example * feat: KEYP-23 update Javadoc and unit tests following a code review * feat: KEYP-23 completed unit tests * Jenkins: use correct version for examples Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> * feat: KEYP-96 add new classes dedicated to Stored Value management * feat: KEYP-96 update transaction classes to handle Stored Value commands * feat: KEYP-96 update unit tests * feat: KEYP-96 add new conversion methods to ByteArrayUtil * feat: KEYP-96 update release notes * feat: KEYP-96 update example Usecase7 Stored Value * feat: KEYP-96 fix build issues (spotless, unit tests) * feat: KEYP-96 update Stored Value commands with load, debit, undebit * feat: KEYP-96 add checkSvSignature, add Javadoc * feat: KEYP-96 fix postponed data length in CloseSessionRespPars * feat: KEYP-96 rename Usecase7_StoredValue_Pcsc to Usecase7_StoredValue_Debit_Pcsc * feat: KEYP-96 add Usecase8_StoredValue_Reload_Pcsc * feat: KEYP-96 add missing features - SV check executed when an SV operation is performed outside a secure session - prepareSvReadAllLogs method to get all SV logs (Stored Value app only) * feat: KEYP-96 refactor the two SV examples * feat: KEYP-96 update SV examples * feat: KEYP-96 spotless * feat: KEYP-96 complete unit tests related to PIN and SV, minor corrections * feat: KEYP-96 some code and Javadoc improvements * feat: KEYP-96 update release notes and improve Javadoc * fix wrong date in some file headers * feat: KEYP-62 add invalidate and rehabilitate command builders and parsers * feat: KEYP-62 add invalidate and rehabilitate prepare commands - update associated unit tests * feat: KEYP-62 fixed a mistake in the prepareRehabilitate Javadoc * feat: KEYP-311 add an Unlock command executed during the selection of SAM - the Unlock command is added when an unlock data is set in the SamSelector. * feat: KEYP-311 change unset unlock data management * feat: KEYP-62 enhance SamSelectionRequest and unit test * Fix: Sonar branch Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> * refact: KEYP-312 reorganize reader plugin package, change access levels - remove monitoring and state subpackages - many methods from abstract reader classes are made package-private or protected * feat: KEYP-312 update unit tests * feat: KEYP-312 update plugins * feat: KEYP-312 update release notes * refact: KEYP-312 remove useless method * Fix:reader.currentMonitoringState is no longer visible Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * refact: KEYP-312 make package-private getMonitoringJob and stop methods - transform MonitoringJob interface into an abstract class - update classes implementing MonitoringJob * refact: KEYP-312 make tracing and debugging calls conditional on log level * refact: KEYP-312 reorganize reader plugin package, change access levels - remove monitoring and state subpackages - many methods from abstract reader classes are made package-private or protected * feat: KEYP-312 update unit tests * feat: KEYP-312 update plugins * feat: KEYP-312 update release notes * refact: KEYP-312 remove useless method * Fix:reader.currentMonitoringState is no longer visible Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * refact: KEYP-312 make package-private getMonitoringJob and stop methods - transform MonitoringJob interface into an abstract class - update classes implementing MonitoringJob * refact: KEYP-312 make tracing and debugging calls conditional on log level * refact: KEYP-312 make AbstractMonitoringJob public * refact: KEYP-312 make package-private forgotten job's stop methods * refact: KEYP-312 ProxyElement interface - make package-private the interface - AbstractSeProxyComponent no more implements ProxyElement - AbstractSeProxyComponent provides an abstract method setParameter to be implemented at plugin level * refact: KEYP-312 the classes of all the subpackages of "local" are grouped in the "plugin" package, protocolMaps - protocolsMap made private, a protected getter is added * refact: KEYP-312 update unit tests following the grouping of classes in plugin * refact: KEYP-312 update plugins following the changes in plugin packages and protocolsMap management * refact: KEYP-312 make getProtocolsMap final * refact: KEYP-312 make SmartInsertionReader and SmartRemovalReader extend ObservableReaderNotifier * refact: KEYP-312 make SmartSelectionReader extend ProxyReader * refact: KEYP-312 add @OverRide, fix comment * refact: KEYP-306 make SeProtocol optional when building PoSelector and SamSelector - default values: PoSelector ISO14443_4, SamSelector ISO7816_3 * refact: KEYP-306 make PoSelector and SamSelector builders final * doc: ALPHA-2 update of the release notes in preparation for the alpha 2 release * refact: KEYP-314 revise channel control - notifySeProcessed is renamed to cancelSeChannel - startRemovalSequence is renamed to terminateSeCommunication and becomes an abstract method (package-private) of AbstractLocalReader - the forceClosing flag is removed * refact: KEYP-314 update unit tests * refact: KEYP-314 update plugin and associated unit tests * refact: KEYP-314 update examples * refact: KEYP-314 update Android examples * refact: KEYP-314 remove cancelSeChannel * refact: KEYP-314 change the PO channel management - add a prepareReleasePoChannel method - remove ChannelControl argument from process commands * refact: KEYP-314 update plugins unit tests * refact: KEYP-314 update examples (Java and Android) * refact: KEYP-314 fix Android examples * refact: KEYP-314 fix Android examples * refact: KEYP-314 fix unit tests * refact: KEYP-314 fix Android CI build * refact: KEYP-314 simplify channel control management in PoTransaction * doc: KEYP-314 update release notes * Refact: Visibility of closeLogicalAndPhysicalChannels in order for plugins to be able to correctly reset state of components. Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * refact: KEYP-316 change channel control management during selection * refact: KEYP-316 correct Javadoc * refact: KEYP-316 Update Android examples * refact: KEYP-316 fix Android Omapi build * refact: KEYP-316 simplify SeSelection usages * refact: KEYP-316 fix typo * refact: KEYP-316 fix spotless * refact: KEYP-317 move ChannelControl from the seproxy to the seproxy.message package * refact: KEYP-317 move ChannelControl from the seproxy to the seproxy.message package #2 * refact: KEYP-320 remove Comparable from ReaderPlugin and SeReader interfaces * refact: KEYP-318 add getters to ReaderEvent to help retrieve the plugin and the reader * refact: KEYP-319 add a method to force channel closure to AbstractObservableReader * refact: KEYP-319 update examples following the addition of finalizeSeProcessing * refact: KEYP-319 update Android code * refact: KEYP-319 fix Javadoc * refact: KEYP-320 remove obsolete unit test * refact: KEYP-316/317/318/319/320 update release notes * fix: KEYP-321 fix error check order during processClosing * refact: KEYP-246 change spotless configuration - the "Google" format replaces the previous one - the format of the header file is updated as well * refact: KEYP-246 apply the new spotless configuration - all source files are updated: format and header * Fix: Spotless alert Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * refact: KEYP-299 Add isKifAvailable and isKvcAvailable methods to DirectoryHeader class * refact: KEYP-236 Improve the logging of SeProtocol errors in Pcsc plugin * fix: KEYP-228 SE monitoring minor issue * refact: Add missing Override directives * fix: KEYP-228 SE monitoring unit test * fix: KEYP-228 fix unit test * Refactor/keyp 323 reader package (#393) * refactor: KEYP-323 move reader classes to a dedicated reader package * Refact: Changed prototype of parameters and methods exposing internal… (#394) * Refact: Changed prototype of parameters and methods exposing internal CoucurrentHashMaps Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: Updating tests Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Refact: Cleaning Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> * Fix/keyp 244 fix blocker and critical issues raised by SonarQube (#397) * fix: KEYP-244 reduce cognitive complexity * fix: KEYP-244 fix keyple-core issues * fix: KEYP-244 fix keyple-core tests issues * fix: KEYP-244 fix keyple-calypso issues * fix: KEYP-244 fix keyple-calypso tests issues * fix: KEYP-244 fix keyple-plugin issues * fix: KEYP-244 remove unnecessary overloads of toString * fix: KEYP-244 another batch of fixes for issues raised by SonarQube * fix: KEYP-244 remove serialVersionUID fields * Fix/keyp 322 transmission mode (#400) * fix: KEYP-322 remove TransmissionMode from AbstractMatchingSe - retrieve the transmission mode from the reader instead of CalypsoPo in PoTransaction * fix: KEYP-322 update the PC/SC plugin - move settings strings in separate classes * fix: KEYP-322 update the PC/SC plugin - change transmission mode management - add the possibility to find the transmission from the reader name (plugin/findTransmissionMode) - correct reader/getTransmissionMode * fix: KEYP-244 update examples * fix: KEYP-322 spotless * fix: KEYP-322 update examples * fix: KEYP-322 spotless * fix: KEYP-322 spotless configuration (examples) * fix: KEYP-322 update examples (Android) * fix: KEYP-322 make SeProtocol truly optional in PoSelector and SamSelector - there is no more SeProtocol defined by default * fix: KEYP-322 update transmission mode management in CalypsoSam related classes * fix: KEYP-322 refinement of PC/SC classes * fix: KEYP-322 various update in PC/SC plugin * refact: KEYP-328 deep reorganisation of examples - suppression and simplification as much as possible of the common elements - simplification of the readers' parameterization - various corrections and optimizations * refact: KEYP-328 make a method final * refact: KEYP-328 improve the naming of properties in the examples * refact: KEYP-328 remove unused PcscReadersSettings class in the examples * refact: KEYP-331 Update example to illustrate sync/async updates * refact: KEYP-331 fix spotless * Fix readme remove docs (#405) * Fix raw readme for version 0.9 * Remove old Core & Calypso API guides, now hosted on keyple.org * readme typo * Release 0.9.0 to develop (#407) * Adding Release to Jenkinsfile Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> * Release keyple-java 0.9.0 Signed-off-by: Brice Ruppen <brice.ruppen@armotic.fr> Co-authored-by: Jean-Pierre Fortune <jean-pierre.fortune@ialto.com> Co-authored-by: OlivierDelcroix <odelcroi@gmail.com> Co-authored-by: Pierre Terree <36192444+pterr@users.noreply.github.com> Co-authored-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> Co-authored-by: Andrei Cristea <andrei.cristea019@gmail.com> * Revert "Release 0.9.0 to master (#408)" This reverts commit a212a42. * Docs: Add legal information (#490) * Docs: Add legal information Signed-off-by: Ludovic Teixeira Costa <ludovic.teixeiracosta@calypsonet.org> * Doc/readme add readme intro (#489) * update(doc) : add readme intro Signed-off-by: OlivierDelcroix <odelcroi@gmail.com> * update(doc) : add maven link Signed-off-by: OlivierDelcroix <odelcroi@gmail.com> * update(doc) : update readme Signed-off-by: OlivierDelcroix <odelcroi@gmail.com> * update(doc) : move to https Signed-off-by: OlivierDelcroix <odelcroi@gmail.com> * Docs: Add legal information Signed-off-by: Ludovic Teixeira Costa <ludovic.teixeiracosta@calypsonet.org> * Docs: Update Contributors list Signed-off-by: Ludovic Teixeira Costa <ludovic.teixeiracosta@calypsonet.org> Co-authored-by: Olivier D <odelcroi@gmail.com> * refact: KEYP-371 Mark SAM manager classes as deprecated and move them to a separate package (#492) * update(doc) : update main readme (#495) Signed-off-by: OlivierDelcroix <odelcroi@gmail.com> * refactor(Distributed): change examples names and description (#494) * refactor(Distributed): change examples names and description * Wrong permissions for gradlew * refactor(Distributed): change examples names and description Co-authored-by: Brice Ruppen <brice.ruppen@armotic.fr> * docs(ReleaseNotes) (#496) * docs(ReleaseNotes) * docs(ReleaseNotes) * Release 1.0.0 * Next development: 1.1.0-SNAPSHOT * Wrong Keyple Gradle version Co-authored-by: Jean-Pierre Fortune <jean-pierre.fortune@ialto.com> Co-authored-by: OlivierDelcroix <odelcroi@gmail.com> Co-authored-by: Pierre Terree <36192444+pterr@users.noreply.github.com> Co-authored-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr> Co-authored-by: Andrei Cristea <andrei.cristea019@gmail.com> Co-authored-by: Ludovic Teixeira Costa <ludovic.teixeiracosta@calypsonet.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and move them to a separate package