add support for languages with specific file names #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydaveluy
force-pushed
the
language_with_filenames
branch
from
1d48483 to
2feaf22
Compare
spoenemann
reviewed
Mar 28, 2025
Contributor
spoenemann
left a comment
spoenemann
left a comment
There was a problem hiding this comment.
Shall we unify the two into filePatterns where an extension is a special case translated to *.ext?
It should be easy to implement by translating the pattern to a regexp: * becomes .* and ? becomes .
montymxb
reviewed
Mar 28, 2025
Contributor
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
Nice! This looks pretty good so far. Just a handful of comments for a couple small things that would be nice to adjust, and one requested change for how we report errors in the service registry.
montymxb
approved these changes
Mar 31, 2025
Contributor
montymxb
left a comment
montymxb
left a comment
There was a problem hiding this comment.
approved! Plus thanks for the changes.
Contributor
|
One last note before we pull this in. Per @spoenemann 's comment above, we can still consider a follow-up PR where we unify the two patterns we're now using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1871
Add an optional fileNames entry in the langium configuration.
In VSCode contributions it is also possible to provide a filenamePatterns: https://code.visualstudio.com/api/references/contribution-points#contributes.languages but to add this to Langium it would requires to add a glob library as dependency.
It changes the API of traverseFolder and includeEntry in workspace-manager.ts so maybe for 4.0 ?