Update to docker-client 10 #530
Conversation
|
/request-license-review |
License review requests:
After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
|
License check fails due to p2/orbit/p2.eclipse.plugin/org.eclipse.draw2d/3.20.100.202508011427 which is content from Eclipse project so merging without waiting for it. |
|
@akurtakov did you have a chance to test this with CDT yet? If not I will try it out (and 🤞 ) |
Uses https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/cdt/updated.target as a source + latest repos for dependencies. We need to use linuxtools docker nightly still as there are some version changes that we need to pick up for 2025-12 in docker-client from org.mandas (see eclipse-linuxtools/org.eclipse.linuxtools#530)
|
Please test . I haven't tested with CDT at all but the changelog wasn't big so I don't expect much changes. |
|
This looks ok to me, CDT works fine. |
|
@akurtakov Should this be cherry-picked into the stable-8.21 branch for RC2? |
|
No let's give it time to be tested. |
Uses https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/cdt/updated.target as a source + latest repos for dependencies. We need to use linuxtools docker nightly still as there are some version changes that we need to pick up for 2025-12 in docker-client from org.mandas (see eclipse-linuxtools/org.eclipse.linuxtools#530)
Uses https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/cdt/updated.target as a source + latest repos for dependencies. We need to use linuxtools docker nightly still as there are some version changes that we need to pick up for 2025-12 in docker-client from org.mandas (see eclipse-linuxtools/org.eclipse.linuxtools#530)
I have since realized (thanks to eclipse-cdt/cdt#1399) is that docker-client 10 is needed to function correctly with docker engine v29 - the latest major version of docker that was released last month I have recommended an end user install the nightly version so that they can get docker working again. |
|
In theory new release of Linux Tools could be done, although it shouldn't be a service release probably as per https://github.com/dmandalidis/docker-client/blob/main/CHANGELOG.md it adds support for latest but drops support for some older versions. |
|
I'm not sure what to do here - because the docker tools are not a root feature in CPP EPP a check for updates will not see it :-( The https://download.eclipse.org/linuxtools/update-docker update site is in the available sites, but off by default. So getting this to users requires them to do some work, like what I outlined in eclipse-cdt/cdt#1399 (comment) As a result, I wouldn't bother with a release now. But we should discuss how to setup for better delivery of these fixes in the future. |
3 participants
No description provided.