Enforce UserWriteMask for special attribute writes#1750
Merged
kevinherron merged 3 commits intoMay 17, 2026
Merged
Conversation
…-userwritemask-bypass # Conflicts: # opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/servicesets/impl/DefaultAccessController.java Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kevinherron/milo/sessions/a7c23c2b-bcfe-4c11-a4c8-a56cc8d388b3 Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UserWriteMaskchecks forRolePermissionsandHistorizingattributes.IllegalArgumentExceptionpath whenUserRolePermissionsis evaluated byWriteMask.forAttribute.Description
UserWriteMaskcheck to all non-Valueattribute writes before running the special-caseRolePermissionsandHistorizingrole-permission checks inDefaultAccessController.UserRolePermissionsas explicitly denied during theUserWriteMaskevaluation (exclude it from theWriteMask.forAttributelookup) so it cannot triggerWriteMask.forAttribute'sdefaultexception while preserving non-writability semantics.RolePermissionsandHistorizingafter theUserWriteMaskcheck and short-circuit further checks whenUserWriteMaskdenies access.DefaultAccessControllerTestthat cover denial and allowance scenarios forRolePermissions,Historizing, andUserRolePermissionsw.r.t.UserWriteMask.Codex Task