Return BadSessionIdInvalid for wrong-channel CloseSession#1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the CTT-expected
BadSessionIdInvalidwhenCloseSessionis sent over a SecureChannel that is not associated with the request's authentication token.CloseSessionhandling for active and not-yet-activated sessions with the Session Multiple negative case.CloseSessionbehavior unchanged when the request arrives on the owning SecureChannel.Key Changes
CloseSessionif it arrives on a different SecureChannel, returningBadSessionIdInvalidinstead ofBadSecureChannelIdInvalid.CreateSessionresponse and a fully activated client session, then confirms the request fails as a service fault with the expected status.Testing
mvn -q -pl opc-ua-sdk/integration-tests -am test -Dtest=CloseSessionWrongChannelTest -Dsurefire.failIfNoSpecifiedTests=falsemvn -q spotless:applymvn -q clean compileReferences
Session Services / Session Multiple / Err-001.js