Add a way to proxy upstream requests instead of external links#460
Merged
amvanbaren merged 1 commit intoeclipse-openvsx:masterfrom Feb 21, 2023
Merged
Conversation
amvanbaren
force-pushed
the
feature/issue-452
branch
from
7548297 to
91d59cb
Compare
amvanbaren
added
the
priority:low
Fixes eclipse-openvsx#452 Added UpstreamProxyService Add url rewriting to UpstreamVSCodeService.java # Conflicts: # server/src/main/java/org/eclipse/openvsx/UpstreamRegistryService.java # server/src/main/java/org/eclipse/openvsx/adapter/UpstreamVSCodeService.java
amvanbaren
force-pushed
the
feature/issue-452
branch
from
7750224 to
5437cc1
Compare
filiptronicek
approved these changes
Feb 20, 2023
Contributor
filiptronicek
left a comment
filiptronicek
left a comment
There was a problem hiding this comment.
- feature seems to work awesome-ly! Rewrites happen correctly and all is well. Thanks!
- when you put the upstream URL as
localhost:8080or similar, fun things happen 😄 - I don't think we need to address potential infinite loops any other way than theRead timed out; nested exception is java.net.SocketTimeoutException: Read timed out. It is most likely enough, but maybe we can take a look later
Contributor
Author
|
@filiptronicek I've opened #675 to keep the upstream infinite loop in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452
Added UpstreamProxyService
Testing steps
dev/application.properties:open-vsx.orglinks are rewritten tolocalhost:8080