Skip to content

Search bar improvements#662

Merged
amvanbaren merged 2 commits intomasterfrom
ft/search-bar-improvements
Feb 14, 2023
Merged

Search bar improvements#662
amvanbaren merged 2 commits intomasterfrom
ft/search-bar-improvements

Conversation

@filiptronicek
Copy link
Copy Markdown
Contributor

Makes the search bar more accessible as well as enabling subsequent keyboard navigation for the sorting toggle

Copy link
Copy Markdown
Contributor

@amvanbaren amvanbaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

EDIT: Space scrolls the page down instead of changing the sort order.

Change charCode 13 to key 'Enter' in namespace-input.tsx
@filiptronicek
Copy link
Copy Markdown
Contributor Author

Awesome, thanks for taking care!

@amvanbaren amvanbaren merged commit 90c7259 into master Feb 14, 2023
yiningwang11 pushed a commit to yiningwang11/openvsx that referenced this pull request Apr 2, 2023
* Search bar improvements

* Remove 'Space' key in extension-list-header.tsx
Change charCode 13 to key 'Enter' in namespace-input.tsx

---------

Co-authored-by: amvanbaren <aart.vanbaren@eclipse-foundation.org>
svor pushed a commit to che-incubator/che-openvsx that referenced this pull request Jul 18, 2023
* Search bar improvements

* Remove 'Space' key in extension-list-header.tsx
Change charCode 13 to key 'Enter' in namespace-input.tsx

---------

Co-authored-by: amvanbaren <aart.vanbaren@eclipse-foundation.org>
@netomi netomi deleted the ft/search-bar-improvements branch December 11, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants