Merged
Conversation
sophokles73
force-pushed
the
update_to_more_recent_k8s_version
branch
from
e74fa61 to
f3024dd
Compare
sophokles73
force-pushed
the
update_to_more_recent_k8s_version
branch
from
f3024dd to
8f48083
Compare
Contributor
Author
|
@calohmn Would you mind taking a look? |
The QPid Dispatch Router tries to create an HTTP server during startup. This HTTP server has been used in k8s probes to determine the router's health status. The creation of the HTTP server may fail if the router is not running with an abundant amount of resources. The right thing to do would probably be to fix the underlying issue that causes the HTTP server to fail, which seems to be caused by a bug in libwebsockets that fails to correctly determine the available resources when running in a kind managed k8s environment. This seems to have been done already in the latest version of libwebsockets but there is no Dispatch Router container image (publicly) available, that uses a version of libwebsockets including the fix. Therefore, this commit changes the k8s probes to check the availability of the internal AMQP listener instead of the healthz resource exposed via the HTTP server. This way, the router might still fail to create the HTTP server but because it is no longer needed, the router it will be considered healthy as long as the internal AMQP listener is available and thus reach the Ready state. Fixes #312
Also updated tools and actions being used by the CI job to most recent versions.
sophokles73
force-pushed
the
update_to_more_recent_k8s_version
branch
from
8f48083 to
7e2dc44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated tools and actions being used by the CI job to most recent versions.