Merged
Conversation
Contributor
jaredgalanis
commented
Jun 28, 2023
jaredgalanis
commented
- we have decided to remove pass-ui-public from pass-docker since https://github.com/eclipse-pass/eclipse-pass.github.io provides the public pages for the eclipse-pass community version of the application and JHU pages will be supported in JHU repositories and JHU infra
- this means the root URL of pass-docker will be the IDP login page
- we have decided to remove pass-ui-public from pass-docker since https://github.com/eclipse-pass/eclipse-pass.github.io provides the public pages for the eclipse-pass community version of the application and JHU pages will be supported in JHU repositories and JHU infra - this means the root URL of pass-docker will be the IDP login page
jabrah
approved these changes
Jun 28, 2023
Contributor
jabrah
left a comment
jabrah
left a comment
There was a problem hiding this comment.
Approved, pending the acceptance tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.