Add ability to run pass-docker in JHU AWS stage environment#345
Merged
Add ability to run pass-docker in JHU AWS stage environment#345
Conversation
Contributor
Author
|
In the ticket, there is this item |
rpoet-jh
force-pushed
the
russ-630-aws-deploy-config
branch
from
921c8bf to
de0ba80
Compare
markpatton
approved these changes
Jul 28, 2023
Contributor
markpatton
left a comment
markpatton
left a comment
There was a problem hiding this comment.
Looks sensible. I was able to run it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL 0.8.0 RELEASE IS DONE
eclipse-pass/main#630
The main changes made are as follows:
**Important note: To run pass-docker locally, the args have changed, see README. Changes will be needed in the deployment script to run local env which I have talked with Christopher about. **