Fix ClassCastException when creating new class from Direct Menu Item#1997
Merged
vogella merged 1 commit intoeclipse-pde:masterfrom Oct 23, 2025
Merged
Conversation
vogella
force-pushed
the
copilot/fix-classcastexception-in-menu
branch
from
f4a3bee to
2413d08
Compare
Contributor
Author
|
@HannesWell are the failing tests tracked somewhere? I don't think they are related to this change. |
vogella
force-pushed
the
copilot/fix-classcastexception-in-menu
branch
from
8032896 to
4eaf9ed
Compare
Creating a new class via the "Class URI" link in the E4 application model editor threw a ClassCastException due to an invalid type conversion in the data binding configuration of AbstractNewClassPage.java. The target-to-model UpdateValueStrategy was missing a converter to transform the String value from the text field into an IPackageFragmentRoot, leading to a failed cast by the default converter. This change introduces StringToPackageFragmentRootConverter to properly map String paths to IPackageFragmentRoot instances and integrates it into the data binding setup. Users can now open the new class wizard and create handler classes without errors.
vogella
force-pushed
the
copilot/fix-classcastexception-in-menu
branch
from
4eaf9ed to
ad7f0e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a new class via the "Class URI" link in the E4 application model
editor threw a ClassCastException due to an invalid type conversion in the
data binding configuration of AbstractNewClassPage.java.
The target-to-model UpdateValueStrategy was missing a converter to transform
the String value from the text field into an IPackageFragmentRoot, leading
to a failed cast by the default converter.
This change introduces StringToPackageFragmentRootConverter to properly map String paths to IPackageFragmentRoot instances and integrates it into
the data binding setup. Users can now open the new class wizard and create
handler classes without errors.