Edge: Improve handling of LocationListener#changed() #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sratz
force-pushed
the
edge-locationlistener
branch
from
60f1e0d to
8cbe448
Compare
HeikoKlare
reviewed
Sep 6, 2024
Comment on lines
629
to
631
| if (url.startsWith("data:text/html;")) { | ||
| url = "about:blank"; | ||
| } |
sratz
force-pushed
the
edge-locationlistener
branch
from
8cbe448 to
30555ed
Compare
Previously, the changed() method was not called consistently. Move the firing of 'changed' LocationEvents in Edge from handleSourceChanged() to handleNavigationCompleted(). Add a test case to Test_org_eclipse_swt_browser_Browser for this scenario (setText() twice).
sratz
force-pushed
the
edge-locationlistener
branch
from
30555ed to
932b4a2
Compare
Member
Author
|
Also added a test case for this scenario. If there are no objections I'd like to merge this Today, so that it's available in the I-builds on Monday. |
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the changed() method was not called consistently.
Move the firing of 'changed' LocationEvents in Edge from handleSourceChanged() to handleNavigationCompleted().
Fixes #1464.