Skip to content

Don't check LocationListener changing js eval on WebkitGTK #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Don't check LocationListener changing js eval on WebkitGTK #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ...t.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,12 +1386,9 @@ public void changed(LocationEvent event) {
"\n changed: fired:" + changedFinished.get() + " evaluated:" + changed;
boolean passed = false;

if (SwtTestUtil.isGTK) {
// Evaluation works in all cases.
passed = changingFinished.get() && changedFinished.get() && changed && changing;
} else if (SwtTestUtil.isCocoa) {
// On Cocoa, evaluation in 'changing' fails.
passed = changingFinished.get() && changedFinished.get() && changed; // && changing (broken)
if (SwtTestUtil.isGTK || SwtTestUtil.isCocoa ) {
// On Webkit/Safari evaluation in 'changing' fails.
passed = changingFinished.get() && changedFinished.get() && changed; // && changed (broken)
} else if (SwtTestUtil.isWindows) {
// On Windows, evaluation inside SWT listeners fails altogether.
// Further, only 'changing' is fired if evaluation is invoked inside listeners.
Expand Down