[win32] Use consistent font zoom retrieval #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akoch-yatta
force-pushed
the
always-use-fontprovider
branch
2 times, most recently
from
21bf53f to
be9b308
Compare
akoch-yatta
changed the title
amartya4256
approved these changes
Apr 23, 2025
amartya4256
reviewed
Apr 23, 2025
| return GC.win32_new(hDC, data); | ||
| } | ||
|
|
||
| int getFontZoom() { |
Contributor
There was a problem hiding this comment.
Just a suggestion, can we not call it getNativeZoom? Since, I am not sure if getFontZoom would make sense for every kind of widget + the method name sounds more relevant to what it returns.
Contributor
Author
There was a problem hiding this comment.
Hmm, yes, makes sense. It is solely used for fonts right now, but that method would not be limited to this purpose. I will rename it.
akoch-yatta
force-pushed
the
always-use-fontprovider
branch
from
be9b308 to
0f4b54f
Compare
HeikoKlare
approved these changes
Apr 23, 2025
amartya4256
approved these changes
Apr 24, 2025
This commit unifies the extraction of the target zoom of a font to be affected by the zoom context of the underlying Widget. Before there were different strategies like getting it from the Shell.
HeikoKlare
force-pushed
the
always-use-fontprovider
branch
from
0f4b54f to
a32a561
Compare
Contributor
|
Version increment check is failing for infrastructure reasons and no further version bump is required here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the extraction of the target zoom of a font to be
affected by the zoom context of the underlying Widget. Before there
were different strategies like getting it from the Shell.