Use proper classloader for finding SVGRasterizer #1965 #2049 #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@iloveeclipse can you / do you want to have a look at or maybe even try this fix for the test issue you had? I have of course already tested with your reproducer (via WSL), in which the issue is solved. |
Member
|
Tomorrow. |
Member
|
But feel free to merge, looks promising. |
Contributor
Author
|
Thank you! Due to lack of working infrastructure, I do not plan to merge now anyway, as we don't have ECA validation, Jenkins build etc. and for this change I would like to have one Jenkins build if possible. |
laeubi
reviewed
Apr 24, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/image/SVGFileFormat.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
issue-2049-1965
branch
from
79f33c0 to
93e6c4f
Compare
iloveeclipse
approved these changes
Apr 24, 2025
…eclipse-platform#2049 When initializing the SVGFileFormat class for loading SVGs, the current context classloader is used by the ServiceLoader to find an SVGRasterizer implementation. This classloader may be incorrect in some cases, i.e., it may not be the plain system classloader or an according OSGi classloader but, e.g., some specific classloader for test execution. This change makes the ServiceLoader use the same classloader for finding an SVGRasterizer implementation than the classloader of the SVGFileFormat class containing the rasterizer reference itself. Fixes eclipse-platform#1965 Fixes eclipse-platform#2049
HeikoKlare
force-pushed
the
issue-2049-1965
branch
from
93e6c4f to
d64ad58
Compare
HannesWell
approved these changes
Apr 24, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Looks very good. Great catch!
When looking at the mentioned issues I didn't thought about this at all, but it makes totally sense.
Contributor
Author
|
Version increment check is failing for infrastructure reasons and no further version bump is required here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the SVGFileFormat class for loading SVGs, the current context classloader is used by the ServiceLoader to find an SVGRasterizer implementation. This classloader may be incorrect in some cases, i.e., it may not be the plain system classloader or an according OSGi classloader but, e.g., some specific classloader for test execution.
This change makes the ServiceLoader use the same classloader for finding an SVGRasterizer implementation than the classloader of the SVGRasterizer class itself.
Fixes #1965
Fixes #2049
Remarks
I am not completely sure if this will always yield a "correct" classloader or whether the classloader of the
SVGRasterizermay also be "wrong".An alternative might be to force classloading of the
SVGFileFormatclass to happen easly in application lifecycle instead of at first usage where the current context classloader may vary.