[win32] Fetch Font#handle through SWTFontProvider #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 539 files - 6 539 suites - 6 29m 30s ⏱️ + 3m 35s For more details on these failures, see this check. Results for commit 35c3b17. ± Comparison against base commit 807b159. This pull request removes 37 tests.♻️ This comment has been updated with latest results. |
akoch-yatta
force-pushed
the
font-handle-via-fontprovider
branch
from
3737757 to
fb0f2ec
Compare
fedejeanne
reviewed
Apr 25, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
The changes look good, just minor comments
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/SWTFontProvider.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
font-handle-via-fontprovider
branch
from
fb0f2ec to
55af4cd
Compare
This commit replaces several calls to Font#handle to use the SWTFontProvider instead. This assures the most Font reusage possible.
fedejeanne
force-pushed
the
font-handle-via-fontprovider
branch
from
55af4cd to
35c3b17
Compare
fedejeanne
approved these changes
Apr 25, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
@akoch-yatta I took the liberty of doing the changes myself. Approved ✔️
Member
arunjose696
added a commit
to vi-eclipse/eclipse.platform.swt
that referenced
this pull request
Jul 31, 2025
Prior to PR eclipse-platform#2062, the hFont variable in Caret::setIMEFont was retrieved directly from the font object (using font.handle). Since eclipse-platform#2602, hFont is fetched via SWTFontProvider, which throws an exception if the font is disposed. Previously, when the font was disposed, hFont (font.handle) would be zero, and the method would fall back to using defaultFont for setting the IME font. After eclipse-platform#2602, this fallback no longer works because the exception is thrown before the fallback can occur. This commit restores the intended behavior by setting hfont as zero if the font is disposed, preventing the exception. Fixes eclipse-platform#2323
arunjose696
added a commit
to vi-eclipse/eclipse.platform.swt
that referenced
this pull request
Jul 31, 2025
Prior to PR eclipse-platform#2062, the hFont variable in Caret::setIMEFont was retrieved directly from the font object (using font.handle). Since eclipse-platform#2602, hFont is fetched via SWTFontProvider, which throws an exception if the font is disposed. Previously, when the font was disposed, hFont (font.handle) would be zero, and the method would fall back to using defaultFont for setting the IME font. After eclipse-platform#2602, this fallback no longer works because the exception is thrown before the fallback can occur. This commit restores the intended behavior by setting hfont as zero if the font is disposed, preventing the exception. Fixes eclipse-platform#2323
arunjose696
added a commit
to vi-eclipse/eclipse.platform.swt
that referenced
this pull request
Aug 1, 2025
Prior to PR eclipse-platform#2062, the hFont variable in Caret::setIMEFont was retrieved directly from the font object (using font.handle). Since eclipse-platform#2602, hFont is fetched via SWTFontProvider, which throws an exception if the font is disposed. Previously, when the font was disposed, hFont (font.handle) would be zero, and the method would fall back to using defaultFont for setting the IME font. After eclipse-platform#2602, this fallback no longer works because the exception is thrown before the fallback can occur. This commit restores the intended behavior by setting hfont as zero if the font is disposed, preventing the exception. Fixes eclipse-platform#2323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces most calls to Font#handle to use the SWTFontProvider instead. This assures the most Font reusage possible.