Skip to content

Conversation

@akoch-yatta
Copy link
Contributor

This commit reverts moving the initialization of GCData.font in Composite#WM_Paint in commit 033d733.

Fixes #2066

This commit reverts moving the initialization of GCData.font in
Composite#WM_Paint in commit 033d733.

Fixes eclipse-platform#2066
@akoch-yatta akoch-yatta linked an issue Apr 25, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

Test Results

   539 files  ±0     539 suites  ±0   31m 53s ⏱️ + 1m 38s
 4 337 tests ±0   4 321 ✅ ±0   15 💤 ±0  1 ❌ ±0 
16 601 runs  ±0  16 463 ✅ ±0  137 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 7e807ab. ± Comparison against base commit ddd1862.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super fast fix!
The change looks good and is safe to do as it just reverts a recent change before which everything worked as expected. I also tested the change and is properly solves the mentioned issue.

Just to be sure: the commit in which the issue was introduced is 504c82b and not 033d733, is it?

@akoch-yatta
Copy link
Contributor Author

Yes, probably copied the wrong hash somehow

@HeikoKlare
Copy link
Contributor

Failing test is unrelated and documented: #1843

Failing version increment check is because of infrastructure issues and no version bump is required here as SWT has already been bumped.

@HeikoKlare HeikoKlare merged commit f92ce76 into eclipse-platform:master Apr 26, 2025
7 of 10 checks passed
@HeikoKlare HeikoKlare deleted the fix-status-line-font branch April 26, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong fonts in status line [Win32] Wrong font in status line

2 participants