Artifacts due to rounding errors in StyledText

[ShahzaibIbrahim]

While selecting the text in code editor the styled text have some artifacts/blank lines due to rounding error while translating points to pixel. Now we are passing the x and y in drawInPixels method in points instead of pixels and expecting it to be scaled up in the method.

How To Test

• Run the RuntimeWorkspace with the following VM Arguments with primary monitor zoom of 175%

-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true

• Write some code/text in the text editor
• Select the code block with mouse
• See if the there are any artifact in between lines

Screenshot

Before:

After:

[github-actions]

Test Results

   545 files  +  9     545 suites  +9   31m 47s ⏱️ + 4m 54s
 4 376 tests +230   4 358 ✅ +225   18 💤 +5  0 ❌ ±0 
16 643 runs  +423  16 503 ✅ +414  140 💤 +9  0 ❌ ±0 

Results for commit fc13d0e. ± Comparison against base commit 2fc2e21.

♻️ This comment has been updated with latest results.

[akoch-yatta]

Looks good to me. Didn't find any issues when testing this. As drawInPixels is a package protected method I think its fine to change the params, there are no usages besides the adapted ones. I don't see any other chance to fix this behavior besides scaling everything together

I only have the two remarks to rename the params in the other drawInPixelsMethods

[fedejeanne]

I'm testing this and I still see the lines:

[HeikoKlare]

Works as expected for me on 175% primary monitor (and also on 125% secondary):

Works for most users, just not for me on my Windows 10

[fedejeanne]

Thank you all for testing it!

Since the problem seems to be on my machine, I accepted this PR because it improves the situation for most users. @ShahzaibIbrahim I would like a follow-up PR to see if we can fix the issue on my machine too, I'll ping you later so you can help me develop it. I assume that the deciding factor here is my Windows 10 since I know that you, Andreas and Heiko all use Windows 11 and I know that Heiko has the exact same monitor that I have (and he also tested with the same configuration that I tested with).