Simplify Spinner test #2169
Merged
Simplify Spinner test #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akurtakov
commented
May 20, 2025
akurtakov
commented
- Use assertThrows
- Do not override parent test method so it actually gets executed
* Use assertThrows * Do not override parent test method so it actually gets executed
Contributor
Test Results 539 files ±0 539 suites ±0 31m 41s ⏱️ +14s For more details on these failures, see this check. Results for commit 496a7c6. ± Comparison against base commit a106143. |
Member
Author
|
Failing tests fails in master too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.