Skip to content

[Win32] Do not set IME font if the font is disposed #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged

[Win32] Do not set IME font if the font is disposed #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/SWTFontProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ public static long getFontHandle(Font font, int zoom) {
if (font == null) {
SWT.error(SWT.ERROR_NULL_ARGUMENT);
}
if (font.isDisposed()) {
return 0;
}
return Font.win32_getHandle(getFont(font.getDevice(), font.getFontData()[0], zoom));
}

Expand Down
11 changes: 11 additions & 0 deletions ...wt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Canvas.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,17 @@ public void test_setFontLorg_eclipse_swt_graphics_Font() {
font.dispose();
}

@Test
public void test_CaretWithDisposedFontDoesNotThrowException_issue2323() {
Caret caret = new Caret(canvas, SWT.NONE);
Font font = new Font(canvas.getDisplay(), "Default", 10, SWT.BOLD);
shell.open();
caret.setFont(font);
font.dispose();
canvas.setFocus();
canvas.setCaret(caret);
}

/* custom*/
@Test
public void test_consistency_MenuDetect() {
Expand Down
Loading