Fix NullPointerException when creating cursor with null device #2414 #2418
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…e-platform#2414 This is a follow-up to e8aadbb which introduced a regression when working with null devices. If null is passed as argument, the value of Device.getDevice() is used as a fallback when initializing this field. This field must be used for all other operations in the constructor, rather than the constructor argument. Closes eclipse-platform#2414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to e8aadbb which introduced a regression when working with null devices.
If null is passed as argument, the value of Device.getDevice() is used as a fallback when initializing this field. This field must be used for all other operations in the constructor, rather than the constructor argument.
Closes #2414