Skip to content

Conversation

@eclipse-releng-bot
Copy link
Contributor

Prepare development of Eclipse 4.39.
This complements:

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

binaries/org.eclipse.swt.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.gtk.linux.aarch64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.gtk.linux.ppc64le/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.gtk.linux.riscv64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.win32.win32.aarch64/META-INF/MANIFEST.MF
binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
bundles/org.eclipse.swt/META-INF/MANIFEST.MF
bundles/org.eclipse.swt/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From fb956f8f4f2ab0012b32bc8038f0de4a9b49bcea Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 28 Nov 2025 14:49:41 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/binaries/org.eclipse.swt.cocoa.macosx.aarch64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
index 126ecc19ba..27e53922f5 100644
--- a/binaries/org.eclipse.swt.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.cocoa.macosx.aarch64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.cocoa.macosx.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
index 799baef7c6..01ecac7b0a 100644
--- a/binaries/org.eclipse.swt.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.cocoa.macosx.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.gtk.linux.aarch64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.gtk.linux.aarch64/META-INF/MANIFEST.MF
index e2a8a8d366..681b6c4a3f 100644
--- a/binaries/org.eclipse.swt.gtk.linux.aarch64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.gtk.linux.aarch64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.gtk.linux.aarch64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.gtk.linux.ppc64le/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.gtk.linux.ppc64le/META-INF/MANIFEST.MF
index f6015be594..6f7de14748 100644
--- a/binaries/org.eclipse.swt.gtk.linux.ppc64le/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.gtk.linux.ppc64le/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.gtk.linux.ppc64le;singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.gtk.linux.riscv64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.gtk.linux.riscv64/META-INF/MANIFEST.MF
index 76d0b4ea31..3f68213975 100644
--- a/binaries/org.eclipse.swt.gtk.linux.riscv64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.gtk.linux.riscv64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.gtk.linux.riscv64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF
index 5ce90b7399..c1e31f5dd9 100644
--- a/binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.gtk.linux.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.win32.win32.aarch64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.win32.win32.aarch64/META-INF/MANIFEST.MF
index 3fd6e01083..a56d66e629 100644
--- a/binaries/org.eclipse.swt.win32.win32.aarch64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.win32.win32.aarch64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.win32.win32.aarch64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
index 84f618f2b6..3dccebb562 100644
--- a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
diff --git a/bundles/org.eclipse.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.swt/META-INF/MANIFEST.MF
index e00e43a3b4..e9c31b3202 100644
--- a/bundles/org.eclipse.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.swt/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: plugin
 DynamicImport-Package: org.eclipse.swt.accessibility2
diff --git a/bundles/org.eclipse.swt/pom.xml b/bundles/org.eclipse.swt/pom.xml
index c1852796cf..18ab858b50 100644
--- a/bundles/org.eclipse.swt/pom.xml
+++ b/bundles/org.eclipse.swt/pom.xml
@@ -20,7 +20,7 @@
         <relativePath>../../</relativePath>
     </parent>
     <artifactId>org.eclipse.swt</artifactId>
-    <version>3.132.0-SNAPSHOT</version>
+    <version>3.132.100-SNAPSHOT</version>
     <packaging>eclipse-plugin</packaging>
 
     <properties>
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Test Results

  118 files  ±0    118 suites  ±0   14m 34s ⏱️ - 1m 41s
4 653 tests ±0  4 635 ✅  - 1  18 💤 +1  0 ❌ ±0 
  338 runs  ±0    334 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 6cc448c. ± Comparison against base commit a0d6ffc.

This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_setUrl_remote_with_post

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

I don't understand why there are API errors:

Error:  Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:5.0.1-SNAPSHOT:verify (verify) on project org.eclipse.swt.gtk.linux.x86_64: There are API errors:
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Point.java:152 The constructor org.eclipse.swt.graphics.Point.OfFloat.OfFloat(float, float, RoundingMode) is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Point.java:178 The method org.eclipse.swt.graphics.Point.OfFloat.clone() is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Point.java:185 The method org.eclipse.swt.graphics.Point.OfFloat.from(Point) is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Point.java:233 The method org.eclipse.swt.graphics.Point.WithMonitor.clone() is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java:428 The constructor org.eclipse.swt.graphics.Rectangle.OfFloat.OfFloat(float, float, float, float, RoundingMode, RoundingMode) is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java:475 The method org.eclipse.swt.graphics.Rectangle.OfFloat.getTopLeft() is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java:479 The method org.eclipse.swt.graphics.Rectangle.OfFloat.getBottomRight() is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java:484 The method org.eclipse.swt.graphics.Rectangle.OfFloat.clone() is no longer an API
Error:  Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java:491 The method org.eclipse.swt.graphics.Rectangle.OfFloat.from(Rectangle) is no longer an API
Error:  META-INF/MANIFEST.MF:6 The major version should be incremented in version 3.132.100, since API breakage occurred since version 3.132.0

All these methods are still there.
@HeikoKlare do you have an idea?

@iloveeclipse
Copy link
Member

@laeubi : I remember you were working in this area in tycho/PDE recently, to get some API data differently. Could that be related? SWT was always "special", with fragments etc.

@HeikoKlare
Copy link
Contributor

It seems like it's exactly those methods that have been added in the current release. It seems like for the preexisting methods, we have added according API filters at the beginning of the previous release cycle: 44d4a11
Maybe we need to extend/replace them as a workaround now?

@HannesWell
Copy link
Member

Maybe we need to extend/replace them as a workaround now?

When reproducing the issue locally it seems like extending the list helps. I'm working on it, but it might take a few minutes and I don't know if I have time to complete it today.

@HeikoKlare
Copy link
Contributor

When reproducing the issue locally it seems like extending the list helps. I'm working on it, but it might take a few minutes and I don't know if I have time to complete it today.

I just started to try them same. The filters look the same for every fragment, so it should be easy to copy over, shouldn't it?

@HannesWell
Copy link
Member

The filters look the same for every fragment, so it should be easy to copy over, shouldn't it?

Yes, just started to apply them partially to see if this works. Try to complete it later.

@HeikoKlare
Copy link
Contributor

It seems to work with the filters you added.

When I added the same method filters locally, I still got this:

There are API errors:
[ERROR] META-INF/MANIFEST.MF:6 The minor version should be incremented in version 3.132.100, since new APIs have been added since version 3.132.0

It's because of the DPITestUtil, which is part of the test sources and thus not even included in the bundle (and its API), but API tooling still seems to compare it. Interesting that this does not happen in the PR.

@HannesWell
Copy link
Member

Thanks for testing. The build looks good. Only Jenkins hang and I restarted it for one more attempt.

It's because of the DPITestUtil, which is part of the test sources and thus not even included in the bundle (and its API), but API tooling still seems to compare it. Interesting that this does not happen in the PR.

I believe this is eclipse-pde/eclipse.pde#1496 (we always have the same problems each time a new stream is opened 😅)

@HannesWell
Copy link
Member

All github workflows pass, so the filter seem to be working now.
Unfortunately the windows-ARM agent is now offline again blocking the completion of the recompilation of all native binaries...
I created an issue, hoping for a quick reaction from the IT team:

Add filters for the new methods added in the previous release cycle.
Similar to
- #2467 (comment)
@HannesWell HannesWell merged commit 4e4c027 into master Nov 29, 2025
8 of 11 checks passed
@HannesWell HannesWell deleted the prepare-R4.39 branch November 29, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants