Fixup warnings due to deprecated URL constructor (in Edge/IE/WebKit) #2842
+176
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes adding a handful of new tests for the code that this modifies to cover all the special cases. The new tests are Linux only, but they could be adapted to test these error conditions on other platforms. Needed to resolve new warnings due to update to Java21 eclipse-platform#2824
These calls are covered by existing Browser test cases. Needed to resolve new warnings due to update to Java21 eclipse-platform#2824
Contributor
Contributor
Author
|
The Jenkins build ran against #2838 which was my whole collection of commits. As we have clean GitHub actions I am merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows tests hit all the cases in Edge/IE. A bunch of code was unreachable for WebKit because WebKit has a bunch of custom code that is not needed on Edge/IE so this PR includes new tests to cover these cases, but they are only run on gtk at the moment.
Needed to resolve new warnings due to update to Java21 #2824