Remove fillRegion() and Region.subtract block in CTabFolderRenderer#3218
Merged
HeikoKlare merged 1 commit intomasterfrom Apr 10, 2026
Merged
Remove fillRegion() and Region.subtract block in CTabFolderRenderer#3218HeikoKlare merged 1 commit intomasterfrom
HeikoKlare merged 1 commit intomasterfrom
Conversation
With square tab corners, the Region.subtract block in drawTabArea that painted parent background into curved-corner cutouts was always empty. Remove it along with the now-unused fillRegion() helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Contributor
Author
|
Fast you are Jedi master @HeikoKlare, I was still testing... But thanks for the merge, up to the next split out... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With square tab corners, the Region.subtract block in drawTabArea that painted parent background into curved-corner cutouts was always empty. Remove it along with the now-unused fillRegion() helper.