Simplify GC.drawImage() test with applied transformation#3268
Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom Apr 24, 2026
Merged
Conversation
The GC test case for drawing images with a transformation applied has an unnecessarily complex assertion. It uses GC's copyArea operation to extract certain parts of a drawing with different transformations applied and compares them with each other. This makes the test implicitly rely on a proper implementation of copyArea(), which should actually be tested independently. This change adapts the test to just create a reference image without any transformations and the actual image created with transforms applied.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GC test case for drawing images with a transformation applied has an unnecessarily complex assertion. It uses GC's copyArea operation to extract certain parts of a drawing with different transformations applied and compares them with each other. This makes the test implicitly rely on a proper implementation of copyArea(), which should actually be tested independently.
This change adapts the test to just create a reference image without any transformations and the actual image created with transforms applied.
This is motivated by
copyArea()actually being broken on macOS for zoom != 100% as revealed by: #3246