Skip to content

Comments

Add support for AllowDarkModeForWindowWithTelemetryId for Windows 11 22H2#424

Merged
SyntevoAlex merged 1 commit intoeclipse-platform:masterfrom
coehlrich:fix-win11-22621-darkmode
Oct 12, 2022
Merged

Add support for AllowDarkModeForWindowWithTelemetryId for Windows 11 22H2#424
SyntevoAlex merged 1 commit intoeclipse-platform:masterfrom
coehlrich:fix-win11-22621-darkmode

Conversation

@coehlrich
Copy link
Contributor

The AllowDarkModeForWindowWithTelemetryId method was changed again in Windows 11 22H2. I haven't checked Windows 10 to see if the AllowDarkModeForWindow method was changed in Windows 10 22H2 or what the build number is for Windows 10 22H2.

@SyntevoAlex
Copy link
Member

Thanks for your contribution! I'm now installing updates, going to test it today.

@SyntevoAlex
Copy link
Member

Thanks, the patch is good!
I checked and alas, the APIs are still not public.

Please rename the commit message to [win32][DarkTheme] Support Win11 22H2 and I'll merge it.

@coehlrich coehlrich force-pushed the fix-win11-22621-darkmode branch from 7575f59 to e590e54 Compare October 8, 2022 23:26
@coehlrich coehlrich force-pushed the fix-win11-22621-darkmode branch from e590e54 to a696d39 Compare October 11, 2022 23:23
@coehlrich
Copy link
Contributor Author

I renamed the commit and did a rebase.

@github-actions
Copy link
Contributor

Unit Test Results

     302 files       302 suites   5m 37s ⏱️
  4 043 tests   4 032 ✔️   8 💤 3
12 057 runs  11 983 ✔️ 70 💤 4

For more details on these failures, see this check.

Results for commit a696d39.

@SyntevoAlex SyntevoAlex merged commit 3504fd5 into eclipse-platform:master Oct 12, 2022
@SyntevoAlex
Copy link
Member

Thanks, it's merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants