Revert "Issue #450 - Control.setFocus must not bring the application to front if it is in the background"#503
Merged
akurtakov merged 1 commit intoeclipse-platform:masterfrom Dec 15, 2022
Conversation
…the application to front if it is in the background" This reverts commit 961810f. The change causes regression in the code that opens new shells and expects some widget to have a focus in that new shell. See comments on eclipse-platform#450
iloveeclipse
requested review from
akurtakov,
lshanmug,
niraj-modi and
sravanlakkimsetti
as code owners
Contributor
Member
Author
|
@akurtakov : thanks for merge, I actually wanted to give Thomas some time about possible fix before merging. |
Member
|
I'm going to run extra I-build for releng changes and I want next build to be usable and the issue wouldn't be solved over night IMO. |
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.text
that referenced
this pull request
Dec 15, 2022
This reverts commit 01906e9 as the original SWT change was reverted too via eclipse-platform/eclipse.platform.swt#503.
iloveeclipse
added a commit
to eclipse-platform/eclipse.platform.text
that referenced
this pull request
Dec 15, 2022
This reverts commit 01906e9 as the original SWT change was reverted too via eclipse-platform/eclipse.platform.swt#503.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 961810f.
The change causes regression in the code that opens new shells and expects some widget to have a focus in that new shell.
See comments on
#450