Skip to content

I20250212-2340

I20250212-2340: [GTK4] Implement correct moveAbove()/moveBelow() control behavior
@ptziegler ptziegler tagged this 12 Feb 12:24 
Regardless of which control are given as input parameters, the controls
are currently always added as last child to their parents. Underlying
issue seems to be that the swt_fixed_restack() method does not handle
the GTK4 widgets correctly. As a solution, perform the movement using
the proper API.

To understand the combination in which GTK methods need to be called,
consider the expected behavior based on the GTK and SWT documentation:

[GTK4 Documentation]

- gtk_widget_insert_after(widget, parent, previous_sibling)

  It will be placed after previous_sibling, or at the beginning if
  previous_sibling is NULL.

- gtk_widget_insert_before(widget, parent, next_sibling)

  It will be placed before next_sibling, or at the end if next_sibling
  is NULL.

[SWT Documentation]

- moveAbove(control)

  Moves the receiver above the specified control in the drawing order.
  If the argument is null, then the receiver is moved to the top of the
  drawing order

This means that if the specified control is NULL,
gtk_widget_insert_after(...) needs to be called, otherwise
gtk_widget_insert_before(...).

- moveBelow(control)

  Moves the receiver below the specified control in the drawing order.
  If the argument is null, then the receiver is moved to the bottom of
  the drawing order.

Here the inverse applies. If the specified control is NULL,
gtk_widget_insert_before(...) needs to be called, otherwise
gtk_widget_insert_after(...).
Assets 2
Loading