Do not inform client listeners for ExpandableNode selection & fix getRawChildren.#1097
Merged
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom Oct 5, 2023
Conversation
raghucssit
force-pushed
the
fix-selection-listener-trigger
branch
from
8ca079d to
5b4be4f
Compare
Contributor
Test Results 854 files - 1 854 suites - 1 1h 23m 21s ⏱️ - 30m 23s For more details on these failures, see this check. Results for commit f72cc98. ± Comparison against base commit ddb10f4. ♻️ This comment has been updated with latest results. |
raghucssit
force-pushed
the
fix-selection-listener-trigger
branch
from
5b4be4f to
fb84662
Compare
raghucssit
added a commit
to raghucssit/eclipse.jdt.ui
that referenced
this pull request
Sep 21, 2023
As we had introduced changes in getRawChildren to return remaining elements as children for ExpandableNode we had to explicitly make this change. Now we don't return remaining elements as children for ExpndableNode. See eclipse-platform/eclipse.platform.ui#1097
raghucssit
force-pushed
the
fix-selection-listener-trigger
branch
from
fb84662 to
9aa23e6
Compare
getRawChildren. Selection is updated before informing clients by removing ExpandableNode. getRawChildren(Object element) no more consider ExpandableNode. Fixes eclipse-platform#1096
iloveeclipse
approved these changes
Oct 5, 2023
iloveeclipse
force-pushed
the
fix-selection-listener-trigger
branch
from
9aa23e6 to
f72cc98
Compare
iloveeclipse
pushed a commit
to raghucssit/eclipse.jdt.ui
that referenced
this pull request
Oct 5, 2023
As we had introduced changes in getRawChildren to return remaining elements as children for ExpandableNode we had to explicitly make this change. Now we don't return remaining elements as children for ExpndableNode. See eclipse-platform/eclipse.platform.ui#1097
iloveeclipse
pushed a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this pull request
Oct 5, 2023
As we had introduced changes in getRawChildren to return remaining elements as children for ExpandableNode we had to explicitly make this change. Now we don't return remaining elements as children for ExpndableNode. See eclipse-platform/eclipse.platform.ui#1097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection is updated before informing clients by removing ExpandableNode.
getRawChildren(Object element) no more consider ExpandableNode.
Fixes #1096