Disable gradients in Form by default #121
Conversation
|
New
Old
Definitely better, lets merge so that it gets a lot of usage during the release phase. |
|
Will I be seeing this change in my IDE or is it something coming from the theme? |
|
Open plugin.xml editor and enjoy. |
| // Examples: Win High Con Black, Win High Con #1, Win High Con #2 | ||
| // (covered in the second part of the OR clause above) | ||
| createColor(IFormColors.TITLE, rgb); | ||
| createColor(IFormColors.TITLE, getSystemColor(SWT.COLOR_TITLE_FOREGROUND)); |
There was a problem hiding this comment.
Even nicer and more consistent with the OS systems would IMHO be to use a gray color as background, not sure if we have a good constant for that.
There was a problem hiding this comment.
The palette is visible running SWT's ControlExample in the "Colors" tab. There are the COLOR_WIDGET_*_SHADOW to serve this. I personally don't mind about which exact color we pick, as long as it's readable, it's a system color and gradients are off by default. So please give a try and suggest a color and I can update.
|
This is how it looks currently in the light theme under Linux with gray background. IMHO this is more inline with the current OS L&F
|
|
The current gray in the light theme seems to fit in nicely with the OS
|
Default color for Forms are changed so that gradients are removed, system colors are used.
mickaelistria
force-pushed
the
flat-forms
branch
from
01bd308 to
9ca6051
Compare
|
@vogella I have changed to use COLOR_WIDGET_LIGHT_SHADOW instead. |
Can you add a screenshot? |
|
|
|
On my Ubuntu
LGTM, +1 |
With #121 form default L&F has been updated to have no gradient anymore.
…form#121) Signed-off-by: azerr <azerr@redhat.com> Signed-off-by: azerr <azerr@redhat.com> Co-authored-by: azerr <azerr@redhat.com>
4 participants
Default color for Forms are changed so that gradients are removed,
system colors are used.