Removes the form styling from the Eclipse default light theme #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With #121 form default L&F has been updated to have no gradient anymore.
Contributor
Author
|
Screenshot:
|
Contributor
Author
|
@mickaelistria WDYT? This will make the forms styling changes you did visible for the default light theme users. |
Contributor
I don't think it's correct to use native colors in the Light Theme if the goal is to have it using an enlighten. By removing this customization, then the color become the native/system ones, which may not be light. Once a theme starts overriding some colors, it needs to cascade into overriding all colors. You can for example try this change on a system that has an overall dark theme, but using the light theme, I guess it would look very inconsistent. |
Contributor
Author
|
@mickaelistria makes sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #121
form default L&F has been updated to have no gradient anymore.