Skip to content

Improve and add assertions for random failing HoverTest #926 #1808 #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Improve and add assertions for random failing HoverTest #926 #1808 #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a97b1da
Improve and add assertions for random failing HoverTest #926 #1808
HeikoKlare Jul 16, 2024
ba6a578
Bump version of org.eclipse.ui.genericeditor.tests for 4.34 stream
HeikoKlare Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.genericeditor.tests;singleton:=true
Bundle-Version: 1.3.500.qualifier
Bundle-Version: 1.3.600.qualifier
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.ui.genericeditor.tests,
Expand Down
67 changes: 37 additions & 30 deletions .../org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests/HoverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@
*/
public class HoverTest extends AbstratGenericEditorTest {

private static final int MAXIMUM_HOVER_RETRY_COUNT = 5;

@Rule
public TestName testName= new TestName();

Expand Down Expand Up @@ -227,38 +229,43 @@ private Object getHoverData(AbstractInformationControlManager manager) {
}

private AbstractInformationControlManager triggerCompletionAndRetrieveInformationControlManager() {
final int caretLocation= 2;
this.editor.selectAndReveal(caretLocation, 0);
final StyledText editorTextWidget= (StyledText) this.editor.getAdapter(Control.class);
new DisplayHelper() {
@Override
protected boolean condition() {
return editorTextWidget.isFocusControl() && editorTextWidget.getSelection().x == caretLocation;
}
}.waitForCondition(editorTextWidget.getDisplay(), 3000);
// sending event to trigger hover computation
editorTextWidget.getShell().forceActive();
editorTextWidget.getShell().setActive();
editorTextWidget.getShell().setFocus();
editorTextWidget.getShell().getDisplay().wake();
Event hoverEvent= new Event();
hoverEvent.widget= editorTextWidget;
hoverEvent.type= SWT.MouseHover;
hoverEvent.x= editorTextWidget.getClientArea().x + 5;
hoverEvent.y= editorTextWidget.getClientArea().y + 5;
hoverEvent.display= editorTextWidget.getDisplay();
hoverEvent.doit= true;
editorTextWidget.getDisplay().setCursorLocation(editorTextWidget.toDisplay(hoverEvent.x, hoverEvent.y));
editorTextWidget.notifyListeners(SWT.MouseHover, hoverEvent);
boolean foundHoverData = false;
int attemptNumber = 0;

ITextViewer viewer= (ITextViewer) new Accessor(editor, AbstractTextEditor.class).invoke("getSourceViewer", new Object[0]);
AbstractInformationControlManager textHoverManager= (AbstractInformationControlManager) new Accessor(viewer, TextViewer.class).get("fTextHoverManager");
// retrieving hover content
new DisplayHelper() {
@Override
protected boolean condition() {
return getHoverData(textHoverManager) != null;
}
}.waitForCondition(hoverEvent.display, 6000);

while (!foundHoverData && attemptNumber++ < MAXIMUM_HOVER_RETRY_COUNT) {
final int caretLocation= 2;
editor.setFocus();
this.editor.selectAndReveal(caretLocation, 0);
final StyledText editorTextWidget= (StyledText) this.editor.getAdapter(Control.class);
new DisplayHelper() {
@Override
protected boolean condition() {
return editorTextWidget.isFocusControl() && editorTextWidget.getSelection().x == caretLocation;
}
}.waitForCondition(editorTextWidget.getDisplay(), 3000);
assertTrue("editor does not have focus", editorTextWidget.isFocusControl());
// sending event to trigger hover computation
Event hoverEvent= new Event();
hoverEvent.widget= editorTextWidget;
hoverEvent.type= SWT.MouseHover;
hoverEvent.x= editorTextWidget.getClientArea().x + 5;
hoverEvent.y= editorTextWidget.getClientArea().y + 5;
hoverEvent.display= editorTextWidget.getDisplay();
hoverEvent.doit= true;
editorTextWidget.getDisplay().setCursorLocation(editorTextWidget.toDisplay(hoverEvent.x, hoverEvent.y));
editorTextWidget.notifyListeners(SWT.MouseHover, hoverEvent);
// retrieving hover content
foundHoverData = new DisplayHelper() {
@Override
protected boolean condition() {
return getHoverData(textHoverManager) != null;
}
}.waitForCondition(hoverEvent.display, 6000);
}
assertTrue("hover data not found", foundHoverData);
return textHoverManager;
}
}
Loading