Find/replace overlay: do not escape selected text when not regex #2270 #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Contributor
Test Results 1 815 files ±0 1 815 suites ±0 1h 30m 40s ⏱️ +29s For more details on these failures, see this check. Results for commit 58f7314. ± Comparison against base commit 0347754. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-2270
branch
from
a3c7388 to
f0519f2
Compare
HeikoKlare
force-pushed
the
issue-2270
branch
from
f0519f2 to
9ce5038
Compare
…pse-platform#2270 When opening the find/replace overlay with a text selection in the target editor, this text is set as the find input to the overlay. When in regex mode, the string is escaped accordingly. Currently, the string is also escaped when regex mode is not activated. With this change, the find input string is not escaped when regex mode is not activated. An according test case is added. Fixes eclipse-platform#2270
HeikoKlare
force-pushed
the
issue-2270
branch
from
9ce5038 to
58f7314
Compare
Contributor
|
I verified this fix and it works fine on below build Eclipse SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the find/replace overlay with a text selection in the target editor, this text is set as the find input to the overlay. When in regex mode, the string is escaped accordingly. Currently, the string is also escaped when regex mode is not activated.
With this change, the find input string is not escaped when regex mode is not activated. An according test case is added.
Fixes #2270