Skip to content

Conversation

@mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Nov 27, 2024

This change includes improvement to the existing dark theme. This has been adopted in all three platform Win, Mac and Linux.
Refer issue: #2114

Changes include:

  • Background color of editor
  • Highlight(underline) of selected tabs in active and inactive parts
  • Outline for selected tabs
  • Background color of selected and unselected tabs
  • Background color of Toolbar

Before:
image

After:
image

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6956e743b8842c52263779364d8bf1298ed194e8 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 27 Nov 2024 08:50:52 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
index 0338462b26..59abbfd238 100644
--- a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.themes;singleton:=true
-Bundle-Version: 1.2.2600.qualifier
+Bundle-Version: 1.2.2700.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.e4.ui.css.swt.theme
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@BeckerWdf
Copy link
Member

Changes include:

  • Background color of editor
  • Highlight(underline) of selected tabs in active and inactive parts
  • Outline for selected tabs
  • Background color of selected and unselected tabs
  • Background color of Toolbar

Can you pls. provide detailed before and after screenshots for each of these topics?

@github-actions
Copy link
Contributor

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 19m 56s ⏱️ - 45m 34s
 7 726 tests ±    0   7 493 ✅  -     2  231 💤 +  3  2 ❌  - 1 
16 226 runs   - 8 113  15 711 ✅  - 7 878  513 💤  - 234  2 ❌  - 1 

For more details on these failures, see this check.

Results for commit b0de322. ± Comparison against base commit 6a3eb35.

This pull request skips 3 tests.
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Nov 27, 2024

Changes include:

  • Background color of editor
  • Highlight(underline) of selected tabs in active and inactive parts
  • Outline for selected tabs
  • Background color of selected and unselected tabs
  • Background color of Toolbar

Can you pls. provide detailed before and after screenshots for each of these topics?

Before:
image

After:
image

@vogella
Copy link
Contributor

vogella commented Nov 27, 2024

Looks great, lets merge this early in this release cycle so that we iron issue out during this release cycle.

Thanks a bunch @mvm-sap.

@vogella vogella merged commit 54adc6a into eclipse-platform:master Nov 27, 2024
14 of 17 checks passed
@vogella
Copy link
Contributor

vogella commented Nov 27, 2024

The org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.e4.ui.workbench.swt: Execute ApiApplication failed error seemed unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants