Fix Workbench.setEdgeDataDirectory(Display) in case of path with spaces #2726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs returned by org.eclipse.osgi.service.datalocation.Location.getDataArea(String) are not strictly valid URIs as well, e.g. they do not properly encode space characters. Do not use #toUri() but let java.io.File(String) deal with it instead. Same approach is also used in org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngine.ThemeEngine constructor. Fixes eclipse-platform#2725.
Christopher-Hermann
approved these changes
Jan 17, 2025
Contributor
HeikoKlare
approved these changes
Jan 17, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Change looks fine and the fix is reasonable given ThemeEngine seems to be using the same approach for more than 10 years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs returned by
org.eclipse.osgi.service.datalocation.Location.getDataArea(String)are not strictly valid URIs as well, e.g. they do not properly encode space characters.Do not use
#toUri()but letjava.io.File(String)deal with it instead.Same approach is also used in
org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngine.ThemeEngineconstructor.Fixes #2725.