Skip to content

Find/Replace overlay can't be disabled by product customization #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

Find/Replace overlay can't be disabled by product customization #2779

merged 1 commit into from
Feb 6, 2025

Conversation

@iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Feb 6, 2025

To read values from all scopes one has to use IPreferencesService, not the InstanceScope!

Fixes #2778

@iloveeclipse
Find/Replace overlay can't be disabled by product customization
4954d9e 
To read values from *all* scopes one has to use IPreferencesService, not
the InstanceScope!

Fixes eclipse-platform#2778
jukzi
jukzi reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hookDialogPreferenceListener(), removeDialogPreferenceListener()
use the same pattern (line 360 ff), do they need adjustment too?

@jukzi
Copy link
Contributor

jukzi commented Feb 6, 2025

also update org.eclipse.ui.internal.findandreplace.overlay.FindReplaceOverlayTest.testDisableOverlayViaPreference()?

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Feb 6, 2025

hookDialogPreferenceListener(), removeDialogPreferenceListener() use the same pattern (line 360 ff), do they need adjustment too?

No. The product preferences do not change during the session, only instance preferences. Therefore listeners and writers are unaffected. Only readers.

Regarding the test: I don't think anyone runs tests with product customization?

@jukzi
Copy link
Contributor

jukzi commented Feb 6, 2025

just thinking that even if it no actual problem at that places it might avoid future copy&paste errors

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Feb 6, 2025

just thinking that even if it no actual problem at that places it might avoid future copy&paste errors

IPreferencesService doesn't have listeners / change capabilities.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 34m 11s ⏱️ +42s
 7 719 tests ±0   7 491 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 318 runs  ±0  23 569 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 4954d9e. ± Comparison against base commit bd93b33.

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Feb 6, 2025

Jörg, if there is no other objections, I plan to merge today.

@iloveeclipse iloveeclipse merged commit 033cedf into eclipse-platform:master Feb 6, 2025
17 checks passed
@iloveeclipse iloveeclipse deleted the find_replace branch February 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jukzi jukzi jukzi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find/Replace overlay can't be disabled by product customization

2 participants

@iloveeclipse @jukzi