Skip to content

Clean Code for bundles/org.eclipse.e4.ui.workbench.renderers.swt#3281

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.e4.ui.workbench.renderers.swt
Sep 18, 2025
Merged

Clean Code for bundles/org.eclipse.e4.ui.workbench.renderers.swt#3281
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.e4.ui.workbench.renderers.swt

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 17, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From a3d724878e6a057a0055d264e289db2d576a6f03 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 18 Sep 2025 03:19:48 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
index 9d5e27c11e..249542c521 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
-Bundle-Version: 0.16.900.qualifier
+Bundle-Version: 0.16.1000.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 17, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 12m 59s ⏱️ + 1m 37s
 8 017 tests ±0   7 771 ✅ ±0  245 💤 ±0  1 ❌ ±0 
23 585 runs  ±0  22 802 ✅ ±0  782 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit e2f25c0. ± Comparison against base commit de7ee8c.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.e4.ui.workbench.renderers.swt branch from 4f69d19 to 9165e9a Compare September 18, 2025 03:15
@akurtakov
Copy link
Copy Markdown
Member

Failing test looks unrelated.

@akurtakov akurtakov merged commit f1633b7 into master Sep 18, 2025
16 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.e4.ui.workbench.renderers.swt branch September 18, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants